Skip to content

Bug with Notifications and states #8

@varet80

Description

@varet80

There is a Bug which prometheus continuesly exports the Notification value even if it is not current.

Story:
I have some Door/Window sensor which has 2 notifications "46-113-0-Access Control-Door state" and "46-113-0-Access Control-Door state (simple}"

Both get the values: [23] Window/door is closed or [22] Window/door is open

this translates to for simple:
Sensor closed

zwave_notification_access_control_door_state_simple{nodeId="46",name="Main Door Contact",location="Yard",commandClass="Notification",property="Access Control",label="Door state (simple)",endpoint="0",id="46-113-0-Access Control-Door state (simple)",propertyKey="Door state (simple)",state="Window/door is open"} 22
zwave_notification_access_control_door_state_simple{nodeId="46",name="Main Door Contact",location="Yard",commandClass="Notification",property="Access Control",label="Door state (simple)",endpoint="0",id="46-113-0-Access Control-Door state (simple)",propertyKey="Door state (simple)",state="Window/door is closed"} 23

Sensor open:

zwave_notification_access_control_door_state_simple{nodeId="46",name="Main Door Contact",location="Yard",commandClass="Notification",property="Access Control",label="Door state (simple)",endpoint="0",id="46-113-0-Access Control-Door state (simple)",propertyKey="Door state (simple)",state="Window/door is closed"} 23
zwave_notification_access_control_door_state_simple{nodeId="46",name="Main Door Contact",location="Yard",commandClass="Notification",property="Access Control",label="Door state (simple)",endpoint="0",id="46-113-0-Access Control-Door state (simple)",propertyKey="Door state (simple)",state="Window/door is open"} 22

this is the same device shown 2 times.
The bug is:
using the state as label, causes to create two metrics for the same device. Which then captures wrong metric data! as one state is invalid.

Suggestion:
Either clean the other state, or remove completely the state and keep the Number only.
I prefer removing the "state" as it is a word which can be easily coded in Grafana using the number.

Same issue with sound_switch states:

zwave_sound_switch_defaulttoneid{nodeId="2",name="Bell",location="Livingroom",commandClass="Sound Switch",property="defaultToneId",label="Default tone ID",endpoint="7",id="2-121-7-defaultToneId",state="Deep Alarm Tone (62 sec)"} 18
zwave_sound_switch_defaulttoneid{nodeId="2",name="Bell",location="Livingroom",commandClass="Sound Switch",property="defaultToneId",label="Default tone ID",endpoint="7",id="2-121-8-defaultToneId",state="Fire Evacuation Buzzer (35 sec)"} 11

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions