Skip to content
lint

feat: Inline context for custom events #1978

Sign in to view logs

feat: Inline context for custom events

feat: Inline context for custom events #1978

Triggered via pull request May 9, 2025 16:04
@keelerm84keelerm84
synchronize #477
mk/sdk-1157/inline-contexts
Status Success
Total duration 3m 7s
Artifacts –

cpp-linter.yml

on: pull_request
cpp-linter
2m 55s
cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

4 errors, 11 warnings, and 2 notices
/contract-tests/client-contract-tests/src/main.cpp:1:10 [clang-diagnostic-error]: contract-tests/client-contract-tests/src/main.cpp#L1
'server.hpp' file not found
/contract-tests/server-contract-tests/src/main.cpp:1:10 [clang-diagnostic-error]: contract-tests/server-contract-tests/src/main.cpp#L1
'server.hpp' file not found
/libs/client-sdk/src/client_impl.cpp:225:19 [clang-diagnostic-error]: libs/client-sdk/src/client_impl.cpp#L225
use of undeclared identifier 'context'; did you mean 'context_'?
/home/runner/boost/boost/boost/include/boost/json/detail/value_from.hpp:151:5 [clang-diagnostic-error]: home/runner/boost/boost/boost/include/boost/json/detail/value_from.hpp#L151
static assertion failed due to requirement '!std::is_same<const launchdarkly::Context &, const launchdarkly::Context &>::value': No suitable tag_invoke overload found for the type
/contract-tests/client-contract-tests/src/main.cpp:21:26 [cppcoreguidelines-init-variables]: contract-tests/client-contract-tests/src/main.cpp#L21
variable 'logger' is not initialized
/contract-tests/client-contract-tests/src/main.cpp:34:14 [readability-identifier-length]: contract-tests/client-contract-tests/src/main.cpp#L34
variable name 'p' is too short, expected at least 3 characters
/contract-tests/client-contract-tests/src/main.cpp:35:16 [cppcoreguidelines-init-variables]: contract-tests/client-contract-tests/src/main.cpp#L35
variable 'srv' is not initialized
/contract-tests/server-contract-tests/src/main.cpp:21:26 [cppcoreguidelines-init-variables]: contract-tests/server-contract-tests/src/main.cpp#L21
variable 'logger' is not initialized
/contract-tests/server-contract-tests/src/main.cpp:34:20 [readability-identifier-length]: contract-tests/server-contract-tests/src/main.cpp#L34
variable name 'p' is too short, expected at least 3 characters
/contract-tests/server-contract-tests/src/main.cpp:35:16 [cppcoreguidelines-init-variables]: contract-tests/server-contract-tests/src/main.cpp#L35
variable 'srv' is not initialized
/libs/client-sdk/src/client_impl.cpp:247:51 [bugprone-easily-swappable-parameters]: libs/client-sdk/src/client_impl.cpp#L247
2 adjacent parameters of 'VariationInternal' of convertible types are easily swapped by mistake
/libs/client-sdk/src/client_impl.hpp:31:5 [readability-inconsistent-declaration-parameter-name]: libs/client-sdk/src/client_impl.hpp#L31
function 'launchdarkly::client_side::ClientImpl::ClientImpl' has a definition with different parameter names
/libs/internal/src/serialization/events/json_events.cpp:58:51 [readability-named-parameter]: libs/internal/src/serialization/events/json_events.cpp#L58
all parameters should be named in a function
/libs/server-sdk/src/events/event_factory.cpp:23:51 [performance-unnecessary-value-param]: libs/server-sdk/src/events/event_factory.cpp#L23
parameter 'detail' is passed by value and only copied once; consider moving it to avoid unnecessary copies
cpp-linter
Failed to restore: Cache service responded with 422
Run clang-format on libs/internal/src/serialization/events/json_events.cpp: libs/internal/src/serialization/events/json_events.cpp#L1
File libs/internal/src/serialization/events/json_events.cpp does not conform to Custom style guidelines. (lines 1)
Run clang-format on libs/server-sdk/src/events/event_factory.cpp: libs/server-sdk/src/events/event_factory.cpp#L1
File libs/server-sdk/src/events/event_factory.cpp does not conform to Custom style guidelines. (lines 46, 47)