feat: Add support for CURL networking. #2043
kinyoklionAnnotations
12 warnings and 10 notices
|
|
|
|
|
/libs/client-sdk/src/data_sources/polling_data_source.hpp:37:45 [readability-named-parameter]:
/libs/client-sdk/src/data_sources/polling_data_source.hpp#L37
all parameters should be named in a function
|
|
/libs/client-sdk/src/data_sources/polling_data_source.cpp:152:32 [cppcoreguidelines-avoid-magic-numbers:
/libs/client-sdk/src/data_sources/polling_data_source.cpp#L152
304 is a magic number; consider replacing it with a named constant
|
|
|
|
/libs/client-sdk/src/data_sources/polling_data_source.cpp:150:32 [cppcoreguidelines-avoid-magic-numbers:
/libs/client-sdk/src/data_sources/polling_data_source.cpp#L150
200 is a magic number; consider replacing it with a named constant
|
|
|
|
|
|
/libs/client-sdk/src/data_sources/polling_data_source.cpp:116:62 [performance-unnecessary-value-param]:
/libs/client-sdk/src/data_sources/polling_data_source.cpp#L116
the parameter 'res' is copied for each invocation but only used as a const reference; consider making it a const reference
|
|
/libs/client-sdk/src/data_sources/polling_data_source.cpp:69:34 [performance-unnecessary-value-param]:
/libs/client-sdk/src/data_sources/polling_data_source.cpp#L69
the parameter 'ioc' is copied for each invocation but only used as a const reference; consider making it a const reference
|
|
cpp-linter
Failed to save: <h2>Our services aren't available right now</h2><p>We're working to restore all services as soon as possible. Please check back soon.</p>0JMXuaAAAAABa7bJY7txzRpnzwKPZgbW2UEhMMzBFREdFMDQxNABFZGdl
|
|
cpp-linter
Failed to restore: Cache service responded with 400
|
|
Run clang-format on libs/internal/src/network/requester.cpp:
libs/internal/src/network/requester.cpp#L0
File libs/internal/src/network/requester.cpp does not conform to Custom style guidelines. (lines 12, 15, 20, 25, 27, 34, 39, 41, 62, 66)
|
|
Run clang-format on libs/internal/src/network/curl_requester.cpp:
libs/internal/src/network/curl_requester.cpp#L0
File libs/internal/src/network/curl_requester.cpp does not conform to Custom style guidelines. (lines 22, 24, 31, 33, 43, 55, 69, 74, 76, 77, 80, 81, 85, 86, 97, 98, 104, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 147, 148, 162, 179, 180, 182, 183, 199, 210, 234, 247, 249)
|
|
Run clang-format on libs/internal/src/events/request_worker.cpp:
libs/internal/src/events/request_worker.cpp#L0
File libs/internal/src/events/request_worker.cpp does not conform to Custom style guidelines. (lines 1)
|
|
Run clang-format on libs/internal/include/launchdarkly/network/requester.hpp:
libs/internal/include/launchdarkly/network/requester.hpp#L0
File libs/internal/include/launchdarkly/network/requester.hpp does not conform to Custom style guidelines. (lines 3, 18, 22, 24, 27, 35, 36, 38, 44)
|
|
Run clang-format on libs/internal/include/launchdarkly/network/curl_requester.hpp:
libs/internal/include/launchdarkly/network/curl_requester.hpp#L0
File libs/internal/include/launchdarkly/network/curl_requester.hpp does not conform to Custom style guidelines. (lines 5, 15, 16, 20, 23, 24, 30)
|
|
Run clang-format on libs/internal/include/launchdarkly/events/detail/request_worker.hpp:
libs/internal/include/launchdarkly/events/detail/request_worker.hpp#L0
File libs/internal/include/launchdarkly/events/detail/request_worker.hpp does not conform to Custom style guidelines. (lines 9)
|
|
Run clang-format on libs/common/src/config/http_properties_builder.cpp:
libs/common/src/config/http_properties_builder.cpp#L0
File libs/common/src/config/http_properties_builder.cpp does not conform to Custom style guidelines. (lines 138, 139, 141, 142)
|
|
Run clang-format on libs/common/include/launchdarkly/config/shared/built/http_properties.hpp:
libs/common/include/launchdarkly/config/shared/built/http_properties.hpp#L0
File libs/common/include/launchdarkly/config/shared/built/http_properties.hpp does not conform to Custom style guidelines. (lines 29, 30, 31, 32, 34, 35, 37, 46, 47, 49, 51, 62)
|
|
Run clang-format on libs/common/include/launchdarkly/config/shared/builders/http_properties_builder.hpp:
libs/common/include/launchdarkly/config/shared/builders/http_properties_builder.hpp#L0
File libs/common/include/launchdarkly/config/shared/builders/http_properties_builder.hpp does not conform to Custom style guidelines. (lines 190, 192)
|
|
Run clang-format on libs/client-sdk/src/data_sources/polling_data_source.cpp:
libs/client-sdk/src/data_sources/polling_data_source.cpp#L0
File libs/client-sdk/src/data_sources/polling_data_source.cpp does not conform to Custom style guidelines. (lines 1)
|