Skip to content
lint

feat: Add tracing hook. #2097

Sign in to view logs

feat: Add tracing hook.

feat: Add tracing hook. #2097

Triggered via pull request October 29, 2025 17:28
@kinyoklionkinyoklion
opened #496
rlamb/tracing-hook
Status Success
Total duration 2m 33s
Artifacts –

cpp-linter.yml

on: pull_request
cpp-linter
2m 22s
cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

3 errors, 8 warnings, and 4 notices
/libs/server-sdk-otel/tests/tracing_hook_test.cpp:8:10 [clang-diagnostic-error]: /libs/server-sdk-otel/tests/tracing_hook_test.cpp#L8
'launchdarkly/server_side/integrations/otel/tracing_hook.hpp' file not found
/libs/server-sdk-otel/src/tracing_hook.cpp:6:10 [clang-diagnostic-error]: /libs/server-sdk-otel/src/tracing_hook.cpp#L6
'launchdarkly/server_side/integrations/otel/tracing_hook.hpp' file not found
/libs/server-sdk-otel/include/launchdarkly/server_side/integrations/otel/tracing_hook.hpp:16:10 [clang-diagnostic-error]: /libs/server-sdk-otel/include/launchdarkly/server_side/integrations/otel/tracing_hook.hpp#L16
'opentelemetry/trace/provider.h' file not found
/libs/server-sdk/src/hooks/hook_executor.cpp:85:20 [modernize-raw-string-literal]: /libs/server-sdk/src/hooks/hook_executor.cpp#L85
escaped string literal can be written as a raw string literal
/libs/server-sdk/src/hooks/hook_executor.cpp:79:20 [modernize-raw-string-literal]: /libs/server-sdk/src/hooks/hook_executor.cpp#L79
escaped string literal can be written as a raw string literal
/libs/server-sdk-otel/tests/tracing_hook_test.cpp:25:17 [cppcoreguidelines-init-variables]: /libs/server-sdk-otel/tests/tracing_hook_test.cpp#L25
variable 'hook' is not initialized
/libs/server-sdk-otel/tests/tracing_hook_test.cpp:14:17 [cppcoreguidelines-init-variables]: /libs/server-sdk-otel/tests/tracing_hook_test.cpp#L14
variable 'hook' is not initialized
/libs/server-sdk-otel/include/launchdarkly/server_side/integrations/otel/tracing_hook.hpp:352:27 [cppcoreguidelines-avoid-non-const-global-variables]: /libs/server-sdk-otel/include/launchdarkly/server_side/integrations/otel/tracing_hook.hpp#L352
variable 'MakeHookContextWithSpan' is non-const and globally accessible, consider making it const
/libs/server-sdk-otel/include/launchdarkly/server_side/integrations/otel/tracing_hook.hpp:143:58 [performance-unnecessary-value-param]: /libs/server-sdk-otel/include/launchdarkly/server_side/integrations/otel/tracing_hook.hpp#L143
the parameter 'environment_id' is copied for each invocation but only used as a const reference; consider making it a const reference
cpp-linter
Failed to save: <h2>Our services aren't available right now</h2><p>We're working to restore all services as soon as possible. Please check back soon.</p>0vE4CaQAAAAAbD8tCE42ARr1zfB+DYTtxUEhYMzFFREdFMDYxMABFZGdl
cpp-linter
Failed to restore: Cache service responded with 400
Run clang-format on libs/server-sdk/src/hooks/hook_executor.cpp: libs/server-sdk/src/hooks/hook_executor.cpp#L0
File libs/server-sdk/src/hooks/hook_executor.cpp does not conform to Custom style guidelines. (lines 43, 44, 70, 71, 80, 86)
Run clang-format on libs/server-sdk-otel/tests/tracing_hook_test.cpp: libs/server-sdk-otel/tests/tracing_hook_test.cpp#L0
File libs/server-sdk-otel/tests/tracing_hook_test.cpp does not conform to Custom style guidelines. (lines 15, 26, 51, 52)
Run clang-format on libs/server-sdk-otel/src/tracing_hook.cpp: libs/server-sdk-otel/src/tracing_hook.cpp#L0
File libs/server-sdk-otel/src/tracing_hook.cpp does not conform to Custom style guidelines. (lines 8, 52, 84, 135, 220, 223, 224, 247)
Run clang-format on libs/server-sdk-otel/include/launchdarkly/server_side/integrations/otel/tracing_hook.hpp: libs/server-sdk-otel/include/launchdarkly/server_side/integrations/otel/tracing_hook.hpp#L0
File libs/server-sdk-otel/include/launchdarkly/server_side/integrations/otel/tracing_hook.hpp does not conform to Custom style guidelines. (lines 9, 32, 74, 78, 83, 175, 177, 189, 199, 205, 347)