refactor: implement fdv2 polling initializer / synchronizer #2201
Annotations
13 warnings and 4 notices
|
cpp-linter
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955, MarkusJx/install-boost@3039450bb3dd2e8630d1cf10ec39cb1da3054bbd. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
/libs/internal/include/launchdarkly/network/asio_requester.hpp:306:52 [performance-unnecessary-value-param]:
/libs/internal/include/launchdarkly/network/asio_requester.hpp#L306
the parameter 'exec' is copied for each invocation but only used as a const reference; consider making it a const reference
|
|
/libs/internal/include/launchdarkly/network/asio_requester.hpp:289:31 [readability-identifier-length]:
/libs/internal/include/launchdarkly/network/asio_requester.hpp#L289
variable name 'h' is too short, expected at least 3 characters
|
|
/libs/internal/include/launchdarkly/network/asio_requester.hpp:287:46 [performance-unnecessary-value-param]:
/libs/internal/include/launchdarkly/network/asio_requester.hpp#L287
the parameter 'req' is copied for each invocation but only used as a const reference; consider making it a const reference
|
|
|
|
|
|
/libs/internal/include/launchdarkly/network/asio_requester.hpp:164:11 [readability-redundant-member-init]:
/libs/internal/include/launchdarkly/network/asio_requester.hpp#L164
initializer for member 'resp_' is redundant
|
|
/libs/internal/include/launchdarkly/network/asio_requester.hpp:151:16 [bugprone-easily-swappable-parameters]:
/libs/internal/include/launchdarkly/network/asio_requester.hpp#L151
2 adjacent parameters of 'FoxyClient' of similar type ('std::chrono::milliseconds') are easily swapped by mistake
|
|
/libs/internal/include/launchdarkly/network/asio_requester.hpp:122:9 [readability-implicit-bool-conversion]:
/libs/internal/include/launchdarkly/network/asio_requester.hpp#L122
implicit conversion 'net::ssl::context *' -> bool
|
|
/libs/internal/include/launchdarkly/network/asio_requester.hpp:50:28 [cppcoreguidelines-avoid-magic-numbers:
/libs/internal/include/launchdarkly/network/asio_requester.hpp#L50
308 is a magic number; consider replacing it with a named constant
|
|
/libs/internal/include/launchdarkly/network/asio_requester.hpp:49:28 [cppcoreguidelines-avoid-magic-numbers:
/libs/internal/include/launchdarkly/network/asio_requester.hpp#L49
301 is a magic number; consider replacing it with a named constant
|
|
cpp-linter
Failed to save: <h2>Our services aren't available right now</h2><p>We're working to restore all services as soon as possible. Please check back soon.</p>0N1DVaQAAAAC+mUhtZN8hRJrso1rwsSMCUEhMMzBFREdFMDIwNwBFZGdl
|
|
cpp-linter
Failed to restore: Cache service responded with 400
|
|
Run clang-format on libs/internal/tests/fdv2_protocol_handler_test.cpp:
libs/internal/tests/fdv2_protocol_handler_test.cpp#L0
File libs/internal/tests/fdv2_protocol_handler_test.cpp does not conform to Custom style guidelines. (lines 29, 30, 54, 70, 73, 74, 77, 78, 98, 100, 101, 120, 121, 140, 145, 146, 159, 167, 177, 178, 193, 219, 248, 249, 271, 272, 282, 283)
|
|
Run clang-format on libs/internal/src/fdv2_protocol_handler.cpp:
libs/internal/src/fdv2_protocol_handler.cpp#L0
File libs/internal/src/fdv2_protocol_handler.cpp does not conform to Custom style guidelines. (lines 37, 58, 59, 87, 106, 107, 146, 184)
|
|
Run clang-format on libs/internal/include/launchdarkly/network/asio_requester.hpp:
libs/internal/include/launchdarkly/network/asio_requester.hpp#L0
File libs/internal/include/launchdarkly/network/asio_requester.hpp does not conform to Custom style guidelines. (lines 288, 289, 290, 291)
|
|
Run clang-format on libs/internal/include/launchdarkly/fdv2_protocol_handler.hpp:
libs/internal/include/launchdarkly/fdv2_protocol_handler.hpp#L0
File libs/internal/include/launchdarkly/fdv2_protocol_handler.hpp does not conform to Custom style guidelines. (lines 31, 32, 33)
|