refactor: add a hook to SSE client to allow changing the target #2242
beekldAnnotations
13 warnings
|
cpp-linter
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955, MarkusJx/install-boost@3039450bb3dd2e8630d1cf10ec39cb1da3054bbd. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
/libs/server-sent-events/src/client.cpp:177:17 [bugprone-unchecked-optional-access]:
/libs/server-sent-events/src/client.cpp#L177
unchecked access to optional value
|
|
/libs/server-sent-events/src/client.cpp:176:17 [bugprone-unchecked-optional-access]:
/libs/server-sent-events/src/client.cpp#L176
unchecked access to optional value
|
|
/libs/server-sent-events/src/client.cpp:168:13 [bugprone-unchecked-optional-access]:
/libs/server-sent-events/src/client.cpp#L168
unchecked access to optional value
|
|
/libs/server-sent-events/src/client.cpp:162:13 [bugprone-unchecked-optional-access]:
/libs/server-sent-events/src/client.cpp#L162
unchecked access to optional value
|
|
/libs/server-sent-events/src/client.cpp:131:23 [bugprone-unchecked-optional-access]:
/libs/server-sent-events/src/client.cpp#L131
unchecked access to optional value
|
|
/libs/server-sent-events/src/client.cpp:96:26 [performance-move-const-arg]:
/libs/server-sent-events/src/client.cpp#L96
passing result of std::move() as a const reference argument; no move will actually happen
|
|
/libs/server-sent-events/src/client.cpp:70:16 [bugprone-easily-swappable-parameters]:
/libs/server-sent-events/src/client.cpp#L70
4 adjacent parameters of 'FoxyClient' of similar type ('std::optional<std::chrono::milliseconds>') are easily swapped by mistake
|
|
/libs/server-sent-events/src/client.cpp:66:45 [performance-unnecessary-value-param]:
/libs/server-sent-events/src/client.cpp#L66
the parameter 'executor' is copied for each invocation but only used as a const reference; consider making it a const reference
|
|
/libs/server-sent-events/src/../include/launchdarkly/sse/client.hpp:49:5 [readability-inconsistent-declaration-parameter-name]:
/libs/server-sent-events/src/../include/launchdarkly/sse/client.hpp#L49
function 'launchdarkly::sse::Builder::Builder' has a definition with different parameter names
|
|
/libs/server-sent-events/include/launchdarkly/sse/client.hpp:227:7 [cppcoreguidelines-special-member-functions]:
/libs/server-sent-events/include/launchdarkly/sse/client.hpp#L227
class 'Client' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
|
|
cpp-linter
Failed to save: <h2>Our services aren't available right now</h2><p>We're working to restore all services as soon as possible. Please check back soon.</p>0N9HvaQAAAADSGnPUgVtQQroXGrcmi75lUEFPRURHRTA1MTYARWRnZQ==
|
|
cpp-linter
Failed to restore: Cache service responded with 400
|