test: cover 200-changeset propagation and post-directive error in FDv1 fallback tests

Author: beekld

libs/server-sdk/tests/fdv2_polling_impl_test.cpp

@@ -71,6 +71,32 @@ TEST(HandleFDv2PollResponseTest, TerminalErrorPropagatesFlag) {
     EXPECT_TRUE(result.fdv1_fallback);
 }
 
+TEST(HandleFDv2PollResponseTest, OkWithChangeSetBodyPropagatesFlag) {
+    auto logger = MakeNullLogger();
+    FDv2ProtocolHandler handler;
+
+    std::string const body =
+        R"({"events":[)"
+        R"({"event":"server-intent","data":{"payloads":[)"
+        R"({"id":"p1","target":1,"intentCode":"xfer-full"}]}},)"
+        R"({"event":"put-object","data":{"version":1,"kind":"flag",)"
+        R"("key":"my-flag","object":{"key":"my-flag","on":true,)"
+        R"("fallthrough":{"variation":0},"variations":[true,false],)"
+        R"("version":1}}},)"
+        R"({"event":"payload-transferred","data":{"state":"abc","version":1}})"
+        R"(]})";
+
+    network::HttpResult::HeadersType headers{{"X-LD-FD-Fallback", "true"}};
+    network::HttpResult res{200, body, std::move(headers)};
+
+    auto result = HandleFDv2PollResponse(res, &handler, logger, "test");
+
+    auto* change_set = std::get_if<FDv2SourceResult::ChangeSet>(&result.value);
+    ASSERT_NE(change_set, nullptr);
+    EXPECT_FALSE(change_set->change_set.data.empty());
+    EXPECT_TRUE(result.fdv1_fallback);
+}
+
 TEST(HandleFDv2PollResponseTest, OkWithMissingBodyPropagatesFlag) {
     auto logger = MakeNullLogger();
     FDv2ProtocolHandler handler;

libs/server-sdk/tests/fdv2_streaming_synchronizer_test.cpp

@@ -751,3 +751,30 @@ TEST(FDv2StreamingSynchronizerTest, SecondResponseWithoutDirectiveClearsFlag) {
     ASSERT_TRUE(result.has_value());
     EXPECT_FALSE(result->fdv1_fallback);
 }
+
+TEST(FDv2StreamingSynchronizerTest, ErrorAfterDirectiveCarriesFlag) {
+    auto logger = MakeNullLogger();
+    IoContextRunner runner;
+
+    FDv2StreamingSynchronizer synchronizer(
+        runner.context().get_executor(), logger,
+        MakeEndpoints("http://localhost"), MakeHttpProperties(), std::nullopt,
+        1s);
+    FDv2StreamingSynchronizerTestPeer::MarkStarted(synchronizer);
+
+    boost::beast::http::response_header<> headers;
+    headers.result(200);
+    headers.set("X-LD-FD-Fallback", "true");
+    FDv2StreamingSynchronizerTestPeer::OnResponse(synchronizer, headers);
+
+    FDv2StreamingSynchronizerTestPeer::OnError(
+        synchronizer,
+        sse::Error{sse::errors::ReadTimeout{std::chrono::milliseconds(0)}});
+
+    auto result = synchronizer.Next(data_model::Selector{}).WaitForResult(2s);
+
+    ASSERT_TRUE(result.has_value());
+    EXPECT_TRUE(
+        std::holds_alternative<FDv2SourceResult::Interrupted>(result->value));
+    EXPECT_TRUE(result->fdv1_fallback);
+}