fix: inline Membership methods so dynamodb/redis dylibs can link

Author: beekld

libs/server-sdk/include/launchdarkly/server_side/integrations/big_segments/big_segment_store_types.hpp

@@ -4,6 +4,7 @@
 #include <optional>
 #include <string>
 #include <unordered_map>
+#include <utility>
 #include <vector>
 
 namespace launchdarkly::server_side::integrations {
@@ -21,6 +22,10 @@ namespace launchdarkly::server_side::integrations {
  * A "segment ref" is the string `<segmentKey>.g<generation>`; the SDK
  * constructs that string when evaluating a flag and passes it to @ref
  * CheckMembership.
+ *
+ * Implemented inline because integration libraries link against the
+ * server-sdk shared library, which only exports the C API — out-of-line
+ * symbols defined here would not be visible to consumers.
  */
 class Membership {
    public:
@@ -29,7 +34,7 @@ class Membership {
      * context is included in / excluded from.
      *
      * If the same segment ref appears in both lists, inclusion wins, matching
-     * the LaunchDarkly Big Segments spec (and the Java/Go SDK behavior).
+     * the LaunchDarkly Big Segments spec.
      *
      * @param included_segment_refs Segment refs the context is explicitly
      * included in.
@@ -38,7 +43,18 @@ class Membership {
      */
     static Membership FromSegmentRefs(
         std::vector<std::string> const& included_segment_refs,
-        std::vector<std::string> const& excluded_segment_refs);
+        std::vector<std::string> const& excluded_segment_refs) {
+        std::unordered_map<std::string, bool> entries;
+        // Excluded first so any overlap is overwritten by the included pass;
+        // inclusion wins per the spec.
+        for (auto const& ref : excluded_segment_refs) {
+            entries[ref] = false;
+        }
+        for (auto const& ref : included_segment_refs) {
+            entries[ref] = true;
+        }
+        return Membership(std::move(entries));
+    }
 
     /**
      * @brief Returns the membership state for a single segment ref.
@@ -48,10 +64,17 @@ class Membership {
      * `std::nullopt` if the segment ref has no entry in this membership.
      */
     [[nodiscard]] std::optional<bool> CheckMembership(
-        std::string const& segment_ref) const;
+        std::string const& segment_ref) const {
+        auto const it = entries_.find(segment_ref);
+        if (it == entries_.end()) {
+            return std::nullopt;
+        }
+        return it->second;
+    }
 
    private:
-    explicit Membership(std::unordered_map<std::string, bool> entries);
+    explicit Membership(std::unordered_map<std::string, bool> entries)
+        : entries_(std::move(entries)) {}
 
     // segment-ref → true (included) / false (excluded). Inclusion is the
     // stored value when a ref appears in both lists at construction time.

libs/server-sdk/src/CMakeLists.txt

@@ -32,7 +32,6 @@ target_sources(${LIBNAME}
         all_flags_state/json_all_flags_state.cpp
         all_flags_state/all_flags_state_builder.cpp
         integrations/data_reader/kinds.cpp
-        integrations/big_segments/big_segment_store_types.cpp
         prereq_event_recorder/prereq_event_recorder.cpp
         prereq_event_recorder/prereq_event_recorder.hpp
         data_components/change_notifier/change_notifier.hpp