docs: fix stale condition and orchestrator doc comments

Author: beekld

libs/server-sdk/src/data_interfaces/source/ifdv2_condition.hpp

@@ -27,8 +27,8 @@ namespace launchdarkly::server_side::data_interfaces {
  * orchestrator builds a fresh condition for each synchronizer activation via
  * an IFDv2ConditionFactory.
  *
- * Close() cancels any pending internal work (e.g., a timer) without resolving
- * the future. After Close() returns the condition's future will not resolve.
+ * Close() cancels any pending internal work (e.g., a timer) and resolves the
+ * future with kCancelled.
  *
  * Implementations must be thread-safe: Execute, Inform, Close, and GetType
  * may be called from any thread.
@@ -58,8 +58,8 @@ class IFDv2Condition {
     virtual void Inform(FDv2SourceResult const& result) = 0;
 
     /**
-     * Cancels any pending internal work and ensures the future will not
-     * resolve. Idempotent.
+     * Cancels any pending internal work and resolves the future returned by
+     * Execute() with kCancelled if it has not already resolved. Idempotent.
      */
     virtual void Close() = 0;
 

libs/server-sdk/src/data_systems/fdv2/conditions.hpp

@@ -138,8 +138,7 @@ class RecoveryConditionFactory final
  * underlying condition. If constructed with no conditions, GetFuture()
  * returns a Future that never resolves.
  *
- * Not thread-safe: the caller is responsible for serializing all method
- * calls.
+ * Thread-safe: GetFuture, Inform, and Close may be called from any thread.
  */
 class Conditions final {
    public:

libs/server-sdk/src/data_systems/fdv2/fdv2_data_system.cpp

@@ -314,38 +314,33 @@ void FDv2DataSystem::OnSynchronizerResult(
     bool got_shutdown = false;
     bool advance = false;
 
-    std::visit(
-        overloaded{
-            [&](Result::ChangeSet& cs) {
-                ApplyChangeSet(std::move(cs.change_set));
-            },
-            [&](Result::Shutdown&) { got_shutdown = true; },
-            [&](Result::Interrupted const& iv) {
-                LD_LOG(logger_, LogLevel::kWarn)
-                    << Identity()
-                    << ": synchronizer interrupted: " << iv.error.Message();
-                status_manager_->SetState(
-                    DataSourceStatus::DataSourceState::kInterrupted,
-                    iv.error.Kind(), iv.error.Message());
-            },
-            [&](Result::TerminalError const& te) {
-                LD_LOG(logger_, LogLevel::kWarn)
-                    << Identity()
-                    << ": synchronizer terminal error: " << te.error.Message();
-                status_manager_->SetState(
-                    DataSourceStatus::DataSourceState::kInterrupted,
-                    te.error.Kind(), te.error.Message());
-                advance = true;
-            },
-            [&](Result::Goodbye const& gb) {
-                // The synchronizer handles goodbye internally (reconnects);
-                // the orchestrator just loops on the same source.
-                LD_LOG(logger_, LogLevel::kDebug)
-                    << Identity() << ": ignoring goodbye from synchronizer"
-                    << (gb.reason ? ": " + *gb.reason : "");
-            },
-        },
-        result.value);
+    std::visit(overloaded{
+                   [&](Result::ChangeSet& cs) {
+                       ApplyChangeSet(std::move(cs.change_set));
+                   },
+                   [&](Result::Shutdown&) { got_shutdown = true; },
+                   [&](Result::Interrupted const& iv) {
+                       LD_LOG(logger_, LogLevel::kWarn)
+                           << Identity() << ": synchronizer interrupted: "
+                           << iv.error.Message();
+                       status_manager_->SetState(
+                           DataSourceStatus::DataSourceState::kInterrupted,
+                           iv.error.Kind(), iv.error.Message());
+                   },
+                   [&](Result::TerminalError const& te) {
+                       LD_LOG(logger_, LogLevel::kWarn)
+                           << Identity() << ": synchronizer terminal error: "
+                           << te.error.Message();
+                       status_manager_->SetState(
+                           DataSourceStatus::DataSourceState::kInterrupted,
+                           te.error.Kind(), te.error.Message());
+                       advance = true;
+                   },
+                   [&](Result::Goodbye const&) {
+                       // The synchronizer handles this internally.
+                   },
+               },
+               result.value);
 
     {
         std::lock_guard<std::mutex> lock(mutex_);

libs/server-sdk/src/data_systems/fdv2/fdv2_data_system.hpp

@@ -99,7 +99,7 @@ namespace launchdarkly::server_side::data_systems {
  *     |  Initializer phase|      ChangeSet(no selector) -> stay, N += 1
  *     |  N = 0, 1, 2, ... |      ChangeSet(selector)    -> go to Sync
  *     |                   |      Interrupted/Terminal   -> stay, N += 1
- *     |                   |      Goodbye/Timeout        -> stay, N += 1
+ *     |                   |      Goodbye                -> stay, N += 1
  *     |                   |      Shutdown               -> [Closed]
  *     +-------------------+
  *               |