From e2b76cecfc3c4122e26b4d6c5fd56ce619a56dde Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Mon, 9 Mar 2026 20:44:54 +0000 Subject: [PATCH 1/4] chore: fix errcheck lint issues in test files Co-Authored-By: mkeeler@launchdarkly.com --- dynamodb_builder_test.go | 5 +++-- dynamodb_test.go | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/dynamodb_builder_test.go b/dynamodb_builder_test.go index 85a91f0..064d01a 100644 --- a/dynamodb_builder_test.go +++ b/dynamodb_builder_test.go @@ -10,6 +10,7 @@ import ( "github.com/aws/aws-sdk-go-v2/aws" "github.com/aws/aws-sdk-go-v2/service/dynamodb" "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" ) func TestDataSourceBuilder(t *testing.T) { @@ -74,8 +75,8 @@ func TestDataSourceBuilder(t *testing.T) { }) t.Run("error for invalid configuration", func(t *testing.T) { - os.Setenv("AWS_CA_BUNDLE", "not a real CA file") - defer os.Setenv("AWS_CA_BUNDLE", "") + require.NoError(t, os.Setenv("AWS_CA_BUNDLE", "not a real CA file")) + defer func() { require.NoError(t, os.Setenv("AWS_CA_BUNDLE", "")) }() ds, err := DataStore("t").Build(subsystems.BasicClientContext{}) assert.Error(t, err) diff --git a/dynamodb_test.go b/dynamodb_test.go index 6c4835a..60f9e1a 100644 --- a/dynamodb_test.go +++ b/dynamodb_test.go @@ -133,7 +133,7 @@ func TestDataStoreSkipsAndLogsTooLargeItem(t *testing.T) { ctx.Logging.Loggers = mockLog.Loggers store, err := makeTestStore("").Build(ctx) require.NoError(t, err) - defer store.Close() + defer store.Close() //nolint:errcheck // test cleanup dataPlusBadItem := makeGoodData() collection := dataPlusBadItem[params.collIndex] @@ -163,7 +163,7 @@ func TestDataStoreSkipsAndLogsTooLargeItem(t *testing.T) { ctx.Logging.Loggers = mockLog.Loggers store, err := makeTestStore("").Build(ctx) require.NoError(t, err) - defer store.Close() + defer store.Close() //nolint:errcheck // test cleanup goodData := makeGoodData() require.NoError(t, store.Init(goodData)) From aae0ba16a9da376719cd706e9ede229077d51458 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Mon, 9 Mar 2026 20:44:54 +0000 Subject: [PATCH 2/4] chore: bump golangci-lint to v2.11.1 Co-Authored-By: mkeeler@launchdarkly.com --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 46c3170..1cc7670 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,5 @@ -GOLANGCI_LINT_VERSION=v1.48.0 +GOLANGCI_LINT_VERSION=v2.11.1 LINTER=./bin/golangci-lint LINTER_VERSION_FILE=./bin/.golangci-lint-version-$(GOLANGCI_LINT_VERSION) From 46cc4451197df412e26764eaf004edb61eff1b23 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Tue, 10 Mar 2026 12:49:51 +0000 Subject: [PATCH 3/4] chore: use t.Cleanup instead of defer require.NoError for env var cleanup Co-Authored-By: mkeeler@launchdarkly.com --- dynamodb_builder_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dynamodb_builder_test.go b/dynamodb_builder_test.go index 2e1ae1f..eb80a1d 100644 --- a/dynamodb_builder_test.go +++ b/dynamodb_builder_test.go @@ -76,7 +76,7 @@ func TestDataSourceBuilder(t *testing.T) { t.Run("error for invalid configuration", func(t *testing.T) { require.NoError(t, os.Setenv("AWS_CA_BUNDLE", "not a real CA file")) - defer func() { require.NoError(t, os.Setenv("AWS_CA_BUNDLE", "")) }() + t.Cleanup(func() { _ = os.Setenv("AWS_CA_BUNDLE", "") }) ds, err := DataStore("t").Build(subsystems.BasicClientContext{}) assert.Error(t, err) From df9c9ae2ce6dad2fcca89f6cbdbaa268863ac470 Mon Sep 17 00:00:00 2001 From: Matthew Keeler Date: Tue, 10 Mar 2026 11:04:27 -0400 Subject: [PATCH 4/4] add codeowners --- CODEOWNERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 8b13789..7f8df27 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1 +1,2 @@ - +# Repository Maintainers +* @launchdarkly/team-sdk-go