PR feedback.

Author: kinyoklion

lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceBase.java

@@ -81,16 +81,17 @@ protected FDv2SourceResult loadData() {
         }
 
         FullDataSet<ItemDescriptor> fullData = builder.build();
-        ChangeSet<ItemDescriptor> changeSet = buildChangeSet(fullData, version);
+        ChangeSet<ItemDescriptor> changeSet = buildChangeSet(fullData);
         return FDv2SourceResult.changeSet(changeSet, false);
     }
 
     /**
      * Builds a ChangeSet from a FullDataSet.
      */
-    private ChangeSet<ItemDescriptor> buildChangeSet(FullDataSet<ItemDescriptor> fullData, int version) {
+    private ChangeSet<ItemDescriptor> buildChangeSet(FullDataSet<ItemDescriptor> fullData) {
         return new ChangeSet<>(
             ChangeSetType.Full,
+            // File data is currently selector-less.
             Selector.EMPTY,
             fullData.getData(),
             null,  // no environment ID for file data
@@ -138,10 +139,6 @@ public DataLoader(List<SourceInfo> sources) {
             this.lastVersion = new AtomicInteger(0);
         }
 
-        public Iterable<SourceInfo> getSources() {
-            return sources;
-        }
-
         /**
          * Loads data from all sources into the builder.
          *

lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceBuilder.java

@@ -126,7 +126,14 @@ public FileDataSourceBuilder duplicateKeysHandling(FileData.DuplicateKeysHandlin
   @Override
   public DataSource build(ClientContext context) {
     LDLogger logger = context.getBaseLogger().subLogger("DataSource");
-    return new FileDataSourceImpl(context.getDataSourceUpdateSink(), sources, autoUpdate, duplicateKeysHandling, logger);
+    return new FileDataSourceImpl(
+        context.getDataSourceUpdateSink(),
+        sources,
+        autoUpdate,
+        duplicateKeysHandling,
+        logger,
+        shouldPersist
+    );
   }
 
   /**

lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceImpl.java

@@ -38,11 +38,12 @@ final class FileDataSourceImpl implements DataSource {
         List<SourceInfo> sources,
         boolean autoUpdate,
         FileData.DuplicateKeysHandling duplicateKeysHandling,
-        LDLogger logger
+        LDLogger logger,
+        boolean persist
     ) {
         this.dataSourceUpdates = dataSourceUpdates;
         this.logger = logger;
-        this.synchronizer = new FileSynchronizer(sources, autoUpdate, duplicateKeysHandling, logger, true);
+        this.synchronizer = new FileSynchronizer(sources, autoUpdate, duplicateKeysHandling, logger, persist);
     }
 
     @Override
@@ -93,7 +94,10 @@ private void runUpdateLoop() {
     private void processResult(FDv2SourceResult result) {
         if (result.getResultType() == FDv2SourceResult.ResultType.CHANGE_SET) {
             // Convert ChangeSet to FullDataSet for legacy init()
-            FullDataSet<ItemDescriptor> fullData = new FullDataSet<>(result.getChangeSet().getData());
+            FullDataSet<ItemDescriptor> fullData = new FullDataSet<>(
+                result.getChangeSet().getData(),
+                result.getChangeSet().shouldPersist()
+            );
             dataSourceUpdates.init(fullData);
             dataSourceUpdates.updateStatus(State.VALID, null);
             inited.set(true);