feat: Move iterable async queue to internal. (#125)

kinyoklion · web-flow · commit 971f4b357575 · 2026-02-03T13:54:28.000-08:00
The IterableAsyncQueue was originally in common, but we've decided it doesn't need to be exposed, so I am moving it to internal. Technically this is breaking, but we have not done a release of an SDK that uses the affected version.  --- > [!NOTE] > **Medium Risk** > This is an API/package move that can break any downstream code importing `IterableAsyncQueue`, but the functional behavior change is minimal and limited to internal utility code. > > **Overview** > Moves `IterableAsyncQueue` from the public `com.launchdarkly.sdk.collections` area into `com.launchdarkly.sdk.internal.collections`, making it explicitly *internal* rather than part of the supported API surface. > > Updates the class and its test to the new package, adds `package-info.java` docs for the new internal package/tests, and removes the old `package-info.java` files from `shared/common`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 869e8a6. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>   --- <a href="https://app.devin.ai/review/launchdarkly/java-core/pull/125"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a>
diff --git a/lib/shared/common/src/main/java/com/launchdarkly/sdk/collections/package-info.java b/lib/shared/common/src/main/java/com/launchdarkly/sdk/collections/package-info.java
diff --git a/lib/shared/common/src/test/java/com/launchdarkly/sdk/collections/package-info.java b/lib/shared/common/src/test/java/com/launchdarkly/sdk/collections/package-info.java
diff --git a/lib/shared/internal/src/main/java/com/launchdarkly/sdk/internal/collections/IterableAsyncQueue.java b/lib/shared/internal/src/main/java/com/launchdarkly/sdk/internal/collections/IterableAsyncQueue.java
@@ -1,4 +1,4 @@
-package com.launchdarkly.sdk.collections;
+package com.launchdarkly.sdk.internal.collections;
 
 import java.util.LinkedList;
 import java.util.concurrent.CompletableFuture;
diff --git a/lib/shared/internal/src/main/java/com/launchdarkly/sdk/internal/collections/package-info.java b/lib/shared/internal/src/main/java/com/launchdarkly/sdk/internal/collections/package-info.java
@@ -0,0 +1,7 @@
+/**
+ * Internal collection utilities.
+ * <p>
+ * This package contains collection utilities used internally by the SDK. Classes in this package
+ * are not part of the public API and may change without notice.
+ */
+package com.launchdarkly.sdk.internal.collections;
diff --git a/lib/shared/internal/src/test/java/com/launchdarkly/sdk/internal/collections/IterableAsyncQueueTest.java b/lib/shared/internal/src/test/java/com/launchdarkly/sdk/internal/collections/IterableAsyncQueueTest.java
@@ -1,4 +1,4 @@
-package com.launchdarkly.sdk.collections;
+package com.launchdarkly.sdk.internal.collections;
 
 import org.junit.Test;
 
diff --git a/lib/shared/internal/src/test/java/com/launchdarkly/sdk/internal/collections/package-info.java b/lib/shared/internal/src/test/java/com/launchdarkly/sdk/internal/collections/package-info.java
@@ -0,0 +1,4 @@
+/**
+ * Tests for internal collection utilities.
+ */
+package com.launchdarkly.sdk.internal.collections;

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-package com.launchdarkly.sdk.collections;`
	`1`	`+package com.launchdarkly.sdk.internal.collections;`
`2`	`2`
`3`	`3`	`import java.util.LinkedList;`
`4`	`4`	`import java.util.concurrent.CompletableFuture;`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +/**
 + * Tests for internal collection utilities.
 + */
 +package com.launchdarkly.sdk.internal.collections;