Fan speed value type is changed in new firmware version

[teanva]

SNMPv2-SMI::enterprises.232.6.2.6.7.1.6.0.1 = INTEGER: 12
SNMPv2-SMI::enterprises.232.6.2.6.7.1.6.0.2 = INTEGER: 12
SNMPv2-SMI::enterprises.232.6.2.6.7.1.6.0.3 = INTEGER: 12
SNMPv2-SMI::enterprises.232.6.2.6.7.1.6.0.4 = INTEGER: 12
SNMPv2-SMI::enterprises.232.6.2.6.7.1.6.0.5 = INTEGER: 12
SNMPv2-SMI::enterprises.232.6.2.6.7.1.6.0.6 = INTEGER: 14

ILO:

Fan Location Redundant Status Speed
Fan 1 System Yes OK 11%
Fan 2 System Yes OK 11%
Fan 3 System Yes OK 12%
Fan 4 System Yes OK 12%
Fan 5 System Yes OK 12%
Fan 6 System Yes OK 12%

check_hpasm:
CRITICAL - fan 1 (system) needs attention, fan 2 (system) needs attention, fan 3 (system) needs attention, fan 4 (system) needs attention, fan 5 (system) needs attention, fan 6 (system) needs attention, System: 'proliant dl380 gen10'

check_hpasm -v:

fan 1 is present, speed is value_12, pctmax is 50%, location is system, redundance is redundant, partner is 2
fan 1 (system) needs attention
fan 2 is present, speed is value_12, pctmax is 50%, location is system, redundance is redundant, partner is 3
fan 2 (system) needs attention
fan 3 is present, speed is value_12, pctmax is 50%, location is system, redundance is redundant, partner is 4
fan 3 (system) needs attention
fan 4 is present, speed is value_12, pctmax is 50%, location is system, redundance is redundant, partner is 5
fan 4 (system) needs attention
fan 5 is present, speed is value_12, pctmax is 50%, location is system, redundance is redundant, partner is 6
fan 5 (system) needs attention
fan 6 is present, speed is value_12, pctmax is 50%, location is system, redundance is redundant, partner is 1
fan 6 (system) needs attention

Fix:

#      cpqHeFltTolFanSpeedValue => {
#          1 => "other",
#          2 => "normal",
#          3 => "high",
#      },

sub check {
  my $self = shift;
  $self->blacklist('f', $self->{cpqHeFltTolFanIndex});
#  $self->add_info(sprintf 'fan %d is %s, speed is %s, pctmax is %s%%, '.
  $self->add_info(sprintf 'fan %d is %s, speed is %s%%, pctmax is %s%%, '.
      'location is %s, redundance is %s, partner is %s',
     $self->{cpqHeFltTolFanIndex}, $self->{cpqHeFltTolFanPresent},
      $self->{cpqHeFltTolFanSpeed}, $self->{cpqHeFltTolFanPctMax},
      $self->{cpqHeFltTolFanLocale}, $self->{cpqHeFltTolFanRedundant},
      $self->{cpqHeFltTolFanRedundantPartner});
  $self->add_extendedinfo(sprintf 'fan_%s=%d%%',
      $self->{cpqHeFltTolFanIndex}, $self->{cpqHeFltTolFanPctMax});
  if ($self->{cpqHeFltTolFanPresent} eq 'present') {
#    if ($self->{cpqHeFltTolFanSpeed} eq 'high') {
    if ($self->{cpqHeFltTolFanSpeed} > $self->{cpqHeFltTolFanPctMax}) {
      $self->add_info(sprintf 'fan %d (%s) runs at high speed',
          $self->{cpqHeFltTolFanIndex}, $self->{cpqHeFltTolFanLocale});
      $self->add_message(CRITICAL, $self->{info});
#    } elsif ($self->{cpqHeFltTolFanSpeed} ne 'normal') {
    } elsif ($self->{cpqHeFltTolFanSpeed} == '0') {
      $self->add_info(sprintf 'fan %d (%s) needs attention',
          $self->{cpqHeFltTolFanIndex}, $self->{cpqHeFltTolFanLocale});
      $self->add_message(CRITICAL, $self->{info});
    }

check_hpasm:
OK - System: 'proliant dl380 gen10'

check_hpasm -v:
fan 1 is present, speed is 12%, pctmax is 50%, location is system, redundance is redundant, partner is 2
fan 2 is present, speed is 12%, pctmax is 50%, location is system, redundance is redundant, partner is 3
fan 3 is present, speed is 12%, pctmax is 50%, location is system, redundance is redundant, partner is 4
fan 4 is present, speed is 12%, pctmax is 50%, location is system, redundance is redundant, partner is 5
fan 5 is present, speed is 12%, pctmax is 50%, location is system, redundance is redundant, partner is 6
fan 6 is present, speed is 12%, pctmax is 50%, location is system, redundance is redundant, partner is 1

[lausser]

Can you do me a favour? I plan a rewrite of this plugin, so it can be more easily be maintained. Can you run
snmpwalk -ObentU ... 1.3.6.1.2.1 > /tmp/hpilo.teanva.snmpwalk
snmpwalk -ObentU ... 1.3.6.1.4.1 >> /tmp/hpilo.teanva.snmpwalk
and mail me the snmpwalk-file to gerhard.lausser@consol.de, so i can simulate the server. I currently have no access to any hp ilo.

[lukasertl]

Hi Gerhard,

are you still in need of the snmpwalk-files? I'm also hit by this issue and could provide the requested info.

[KonstantinasK-1205]

Hello, sorry for reviving old thread, but we also been hit with this issue and made changes to resolve it, till official fix comes out.
Maybe it can help other users.

As we have multiple servers, with various iLO versions, I made corresponding changes, to make sure both old and new iLO would work.

sub check {
  my $self = shift;
  $self->blacklist('f', $self->{cpqHeFltTolFanIndex});
  $self->add_info(sprintf 'fan %d is %s, speed is %s, pctmax is %s%%, '.
      'location is %s, redundance is %s, partner is %s',
      $self->{cpqHeFltTolFanIndex}, $self->{cpqHeFltTolFanPresent},
      $self->{cpqHeFltTolFanSpeed}, $self->{cpqHeFltTolFanPctMax},
      $self->{cpqHeFltTolFanLocale}, $self->{cpqHeFltTolFanRedundant},
      $self->{cpqHeFltTolFanRedundantPartner});
  $self->add_extendedinfo(sprintf 'fan_%s=%d%%',
      $self->{cpqHeFltTolFanIndex}, $self->{cpqHeFltTolFanPctMax});
  if ($self->{cpqHeFltTolFanPresent} eq 'present') {
    # New iLO added value_ to its FAN output, so we gonna use that when checking output
    # And update cpqHeFltTolFanSpeed values only for new iLO
    if (index($self->{cpqHeFltTolFanSpeed}, "value_") != -1) {
          # Remove prefix 'value_'
          $self->{cpqHeFltTolFanSpeed} =~ s/^value_//;

          # As no documenation is available, to what normal/high is correlated to %
          # Lets define our ranges (dynamically), based on other hpasm outputs
          # If for any reason, we need other values, edit here
          #
          # As example:
          # cpqHeFltTolFanPctMax = 50;
          my $low_min = $self->{cpqHeFltTolFanPctMax} * 0.1; # 5
          my $high_min = $self->{cpqHeFltTolFanPctMax} * 0.8; # 40

          # Check current FanSpeed based on our calculations above
          # And assign them 'Normal | High' values
          # Logic:
          # If FanSpeed drops below $low_min, then fan is probably degraded, better check than to be sorry = Critical
          # If FanSpeed exceed ..FanPctMax, then it should count as = Critical
          if ($self->{cpqHeFltTolFanSpeed} >= $low_min && $self->{cpqHeFltTolFanSpeed} < $high_min) {
                $self->{cpqHeFltTolFanSpeed} = "normal";
          } elsif ($self->{cpqHeFltTolFanSpeed} >= $high_min && $self->{cpqHeFtlTolFanSpeed} <= $self->{cpqHeFltTolFanPctMax}) {
                $self->{cpqHeFltTolFanSpeed} = "high";
          }
    }
    if ($self->{cpqHeFltTolFanSpeed} eq 'high') {
      $self->add_info(sprintf 'fan %d (%s) runs at high speed',
          $self->{cpqHeFltTolFanIndex}, $self->{cpqHeFltTolFanLocale});
      $self->add_message(CRITICAL, $self->{info});
    } elsif ($self->{cpqHeFltTolFanSpeed} ne 'normal') {
      $self->add_info(sprintf 'fan %d (%s) needs attention',
          $self->{cpqHeFltTolFanIndex}, $self->{cpqHeFltTolFanLocale});
      $self->add_message(CRITICAL, $self->{info});
    }
.....

That way chech_hpasm should work on both old and new iLO and shouldn't impact any legitimate errors