Skip to content

Notify tests use tight timeouts that may cause flakiness under load #127

Description

@coderabbitai

Context

In crates/comenqd/src/worker.rs at lines 305-352, the new notify_one tests use tight timeouts:

  • Duration::from_millis(50) in notify_one_buffers_permit_when_no_waiters
  • Duration::from_millis(100) in notify_one_wakes_exactly_one_waiter
  • Duration::from_millis(10) sleep for waiter registration

Issue

These tight timeouts can reintroduce test flakiness under load or on slower CI runners, particularly when multiple tests run concurrently. Scheduler delays or system load could cause legitimate test failures.

Recommendation

Consider using the existing TimeoutConfig helper (from crates/comenqd/tests/util.rs) or slightly larger timeout bounds to maintain test intent whilst reducing scheduling sensitivity.

References

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions