Improve encapsulation of ParsedSpans struct

[coderabbitai]

The ParsedSpans struct currently exposes all fields as public, which allows external mutation and breaks encapsulation principles. This makes it difficult to maintain invariants (such as sorted and non-overlapping spans) and complicates future extensions without breaking changes.

The struct should be refactored to:

• Make fields private
• Provide a public constructor method
• Expose read-only access through getter methods
• Consider adding #[non_exhaustive] for future extensibility

This issue was raised during code review and requested to be tracked separately.

References:

• Original PR: Refactor parser span handling #48
• Comment: Refactor parser span handling #48 (comment)
• Issue: Improve encapsulation of ParsedSpans struct #52

[leynos]

@coderabbitai is this issue still relevant?

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

I'll check the details of issue #52 and analyze the current codebase to determine if it's still relevant.

---

🏁 Script executed:

#!/bin/bash
# Fetch the details of issue #52
gh issue view 52 --json title,body,state,labels,createdAt,updatedAt,comments

Length of output: 1416

---

Now let me examine the current state of the ParsedSpans struct in the codebase to see if the encapsulation issues mentioned in the issue still exist.

---

🏁 Script executed:

#!/bin/bash
# Search for ParsedSpans struct definition
rg "struct ParsedSpans" -A 10 -B 2

Length of output: 709

---

🏁 Script executed:

#!/bin/bash
# Let's also check if there are any constructor methods or getter methods for ParsedSpans
rg "impl.*ParsedSpans" -A 20

Length of output: 963

---

🏁 Script executed:

#!/bin/bash
# Let's see the complete ParsedSpans struct definition
rg "pub struct ParsedSpans" -A 20

Length of output: 1045

---

@leynos Yes, issue #52 is still relevant.

Looking at the current ParsedSpans struct in src/parser/mod.rs, none of the encapsulation improvements mentioned in the issue have been implemented:

Current state:

• All fields are still public (pub imports, pub typedefs, pub relations, etc.)
• No public constructor method exists
• No getter methods for controlled access
• Missing #[non_exhaustive] attribute
• Only has a private assert_sorted() method for validation

The issue remains valid because:

1. External code can still directly mutate the fields, potentially breaking the sorted and non-overlapping invariants
2. The struct lacks proper encapsulation, making it difficult to maintain data integrity
3. Future extensions could introduce breaking changes without #[non_exhaustive]

The struct still needs the refactoring outlined in the issue to improve its encapsulation and maintainability.

[leynos]

https://chatgpt.com/codex/tasks/task_e_68953b8e6aec8322b4a6306a5947164a