Refactor `body_literals` to eliminate unnecessary helper functions and simplify logic

[sourcery-ai]

The current implementation of the body_literals function relies on several small helper functions (extract_literals_from_body, process_body_element, process_token, and add_literal_if_not_empty) to parse and collect body literals. This approach increases code complexity and can be simplified.

Suggested Improvement:
Refactor body_literals to perform a single pass that collects and splits the body text, eliminating the need for the four helper functions. The new implementation would:

• Skip tokens up to and including the :- token.
• Collect all tokens until the terminating ..
• Concatenate the text, split on commas, trim whitespace, and discard empty pieces.

Example Implementation:

#[must_use]
pub fn body_literals(&self) -> Vec<String> {
    use rowan::NodeOrToken;
    use crate::SyntaxKind::{T_DOT, T_IMPLIES};

    // Skip up through the “:-” token, take everything until the terminating “.”
    let body_text: String = self.syntax
        .children_with_tokens()
        .skip_while(|e| e.kind() != T_IMPLIES)
        .skip(1)  // drop the “:-”
        .take_while(|e| e.kind() != T_DOT)
        .map(|e| match e {
            NodeOrToken::Node(n) => n.text().to_string(),
            NodeOrToken::Token(t) => t.text().to_string(),
        })
        .collect();

    // Split on commas, trim, and discard any empty pieces
    body_text
        .split(',')
        .map(str::trim)
        .filter(|lit| !lit.is_empty())
        .map(str::to_string)
        .collect()
}

Action Items:

• Refactor body_literals as described above.
• Remove the now-unnecessary helper functions.
• Ensure all tests pass and output remains unchanged.

This change will simplify the codebase and improve maintainability.

---

I created this issue for @leynos from #89 (comment).

Tips and commands

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[leynos]

@coderabbitai looking at the codebase, is this issue still relevant? If the issue has been fixed in the code, does the documentation reflect this?

If it is still relevant, please provide an assessment of the issue criticality (critical, high, medium or low), based on risk of the issue impacting the user and the anticipated blast radius.\n\nOnce a decision has been made, apply the appropriate label.

If the issue is documentation ONLY (i.e., no code changes needed), apply the documentation label in addition to the appropriate criticality label.

Please also provide an impact of the required changes.

[coderabbitai]

This refactoring has already been completed. The body_literals function is now implemented simply without the helper functions mentioned in this issue.

[coderabbitai]

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Fetch details of issue #91
gh issue view 91 --json title,body,labels,state,author

Length of output: 2560

---

🏁 Script executed:

#!/bin/bash
# Search for the body_literals function implementation
echo "=== Searching for body_literals function ==="
rg -n -A 20 'pub fn body_literals' --type rust

echo -e "\n=== Searching for helper functions mentioned in the issue ==="
rg -n 'extract_literals_from_body|process_body_element|process_token|add_literal_if_not_empty' --type rust

Length of output: 1741

---

🏁 Script executed:

#!/bin/bash
# Check PR #89 details and when it was merged
echo "=== PR #89 Details ==="
gh pr view 89 --json title,state,mergedAt,body,url

echo -e "\n=== Check git history of rule.rs file to see when body_literals was changed ==="
git log --oneline --all --follow -p src/parser/ast/rule.rs | grep -A 10 -B 2 "body_literals" | head -60

echo -e "\n=== Search for any documentation mentioning body_literals ==="
fd -e md -e txt -e rst | xargs grep -l "body_literals" 2>/dev/null || echo "No documentation found mentioning body_literals"

Length of output: 3479

---

@leynos, this issue is no longer relevant — the refactoring has already been completed.

Analysis

The body_literals function in src/parser/ast/rule.rs (lines 74-79) has already been refactored into a simple implementation:

pub fn body_literals(&self) -> Vec<String> {
    self.body_expression_nodes()
        .into_iter()
        .map(|expr| expr.text().trim().to_string())
        .collect()
}

The four helper functions mentioned in the issue (extract_literals_from_body, process_body_element, process_token, and add_literal_if_not_empty) no longer exist in the codebase. The git history confirms the refactoring was completed as part of PR #89, which was merged on 2025-07-20.

Documentation Status

No documentation references body_literals, so no documentation updates are required.

Recommendation

Close this issue as already resolved. The suggested refactoring was implemented during or before the PR #89 merge, making this issue obsolete.

---

🏁 Script executed:

#!/bin/bash
# Close the issue with a resolution comment
gh issue close 91 --comment "This refactoring has already been completed. The body_literals function is now implemented simply without the helper functions mentioned in this issue."

Length of output: 119

---

✅ Issue #91 has been closed as the refactoring was already completed.

The suggested code simplification had been implemented prior to or during the merge of PR #89 in July 2025, eliminating the need for the four helper functions and reducing body_literals to a simple 5-line implementation. No further action or documentation updates are required.