Consider making split_top_level function public or moving to parse_utils

[coderabbitai]

A refactoring suggestion was made during code review to improve code reusability.

The split_top_level helper function in src/syntax_utils.rs (lines 44-64) implements useful string parsing logic that could benefit other modules. The function currently has private visibility but contains logic that could be reused across the codebase.

Suggested approaches:

• Make the function public by adding the pub keyword
• Move the function to the shared parse_utils module

Context:

• Original suggestion from PR review: Refactor parser AST into modules #89 (comment)
• Related PR: Refactor parser AST into modules #89
• Requested by: @leynos

[leynos]

@coderabbitai looking at the codebase, is this issue still relevant? If the issue has been fixed in the code, does the documentation reflect this?

If it is still relevant, please provide an assessment of the issue criticality (critical, high, medium or low), based on risk of the issue impacting the user and the anticipated blast radius.\n\nOnce a decision has been made, apply the appropriate label.

If the issue is documentation ONLY (i.e., no code changes needed), apply the documentation label in addition to the appropriate criticality label.

Please also provide an impact of the required changes.

[coderabbitai]

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Fetch issue #95 details
gh issue view 95 --json title,body,labels,state,createdAt,updatedAt

Length of output: 873

---

🏁 Script executed:

#!/bin/bash
# Check if src/syntax_utils.rs exists and look at the split_top_level function
cat src/syntax_utils.rs

Length of output: 2039

---

🏁 Script executed:

#!/bin/bash
# Check if parse_utils module exists and examine its structure
fd -p "parse_utils.rs" --type f

# Also search for any attempts to use split_top_level from other modules
rg -n "split_top_level" -C2

# Look for similar comma-splitting or parsing patterns that might benefit from this function
rg -n "split.*,.*depth" -C2

# Check for other occurrences of comma-separated parsing with nested structures
rg -n "char_indices.*match.*'\\('" -C3

Length of output: 1154

---

🏁 Script executed:

#!/bin/bash
# Look at the split_top_level_commas function to compare with split_top_level
cat src/parser/ast/rule_head.rs | sed -n '213,240p'

# Find parse_utils module
fd "parse_utils" --type f

# Also check if there's a mod declaration
rg -n "mod parse_utils" -C1

Length of output: 982

---

🏁 Script executed:

#!/bin/bash
# Examine parse_utils module
fd "parse_utils.rs" --exec cat {}

# Check documentation
fd "README.md" --exec cat {}
fd "CONTRIBUTING.md" --exec cat {}

# Search for any documentation comments about code organization or utilities
rg -n "//!" src/parser/ast/parse_utils.rs -A 5 2>/dev/null || echo "No doc comments found in parse_utils"

Length of output: 656

---

🏁 Script executed:

#!/bin/bash
# Get parse_utils module contents more directly
cat src/parser/ast/parse_utils.rs

# Also check what's currently exported from parse_utils
rg -n "^pub " src/parser/ast/parse_utils.rs

# Look for any recent changes to these files
git log --oneline --since="2025-07-20" -- src/syntax_utils.rs src/parser/ast/rule_head.rs src/parser/ast/parse_utils.rs 2>/dev/null || echo "Git history check skipped"

Length of output: 373

---

🏁 Script executed:

#!/bin/bash
# Check if parse_utils is a directory
fd "parse_utils" --type d

# Check the ast/mod.rs file for inline module or more context
cat src/parser/ast/mod.rs

# Also check if parse_utils functionality is defined elsewhere
rg -n "extract_delimited" -C3

Length of output: 9452

---

🏁 Script executed:

#!/bin/bash
# Check parse_utils directory structure
ls -la src/parser/ast/parse_utils/

# Read the parse_utils mod.rs file
cat src/parser/ast/parse_utils/mod.rs

# Look at the delimiter module that was referenced
cat src/parser/ast/parse_utils/delimiter.rs | head -100

Length of output: 5018

---

@leynos, I've analysed issue #95 and the codebase. Here's my assessment:

Relevance

Yes, this issue is still relevant. The split_top_level function in src/syntax_utils.rs (lines 44-64) remains private and has not been made public or moved to the parse_utils module.

Evidence of Code Duplication

I found evidence supporting the refactoring suggestion. There's a similar function split_top_level_commas in src/parser/ast/rule_head.rs (line 213) that performs comparable comma-splitting logic whilst tracking delimiter depth. Both functions:

• Split on commas at the top level
• Track nesting depth to avoid splitting inside nested structures
• Handle parentheses/delimiters appropriately

The parse_utils module exists at src/parser/ast/parse_utils/ and already contains shared parsing utilities like extract_delimited, making it an appropriate location for this function.

Criticality Assessment

LOW

Justification:

• Risk: This is a code quality and maintainability issue, not a functional bug
• User Impact: None - users are not directly affected; current code functions correctly
• Blast Radius: Small - limited to internal code organisation
• Benefit: Would reduce duplication and improve maintainability

Impact of Required Changes

The refactoring would involve:

1. Moving split_top_level to parse_utils module or making it public
2. Potentially refactoring split_top_level_commas to leverage the shared utility
3. Updating imports in consuming code

Risk Level: Low - straightforward internal refactoring with no API changes
Effort: Small - primarily moving/exposing existing code

Documentation

The README.md contains logging configuration but doesn't address code organisation for utilities. The documentation doesn't need updating for this change as it's internal.

---

🏁 Script executed:

#!/bin/bash
# Apply the low criticality label
gh issue edit 95 --add-label "low"

Length of output: 42

---

✓ Applied the low criticality label to issue #95.

This issue requires code refactoring (not documentation only), so I have not applied the documentation label. The changes would involve moving or exposing the split_top_level function to improve code reusability and reduce duplication with split_top_level_commas.