📝 CodeRabbit Chat: Implement requested code changes

[coderabbitai]

Code changes was requested by @leynos.

• Extend Symbol with precise identifier span and two-provenance model #256 (comment)

The following files were modified:

• src/parser/ast/mod.rs

Summary by Sourcery

Enhancements:

• Simplify identifier span lookup in the AST by replacing manual looping and control flow with iterator-based combinators for clearer, more concise logic.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors the AST identifier span search helper to use iterator combinators (find_map, then_some, and then) instead of an explicit loop and manual control flow, preserving behavior while simplifying the code in the AST parser module.

File-Level Changes

Change	Details	Files
Refactor identifier span search to use iterator combinators while preserving semantics.	Replace the explicit for loop over children_with_tokens with find_map on the iterator to return the first matching span directly. For identifier tokens, compute the token span and use span_contains(...).then_some(token_span) instead of an if plus early return. For child nodes, gate recursion with `ranges_overlap(...).then(

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Important

Review skipped

This PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 31014122-001f-443b-8677-67be6b505fa2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• In the NodeOrToken::Node arm, consider replacing ranges_overlap(...).then(|| find_identifier_span_in_range(...)).flatten() with if ranges_overlap(...) { find_identifier_span_in_range(...) } else { None } (or and_then) to avoid the intermediate Option<Option<_>> and improve readability.
• The NodeOrToken::Token(_) => None arm could be simplified by using a wildcard match arm (e.g., _ => None) if there are no other variants to handle, making the match slightly more concise.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In the `NodeOrToken::Node` arm, consider replacing `ranges_overlap(...).then(|| find_identifier_span_in_range(...)).flatten()` with `if ranges_overlap(...) { find_identifier_span_in_range(...) } else { None }` (or `and_then`) to avoid the intermediate `Option<Option<_>>` and improve readability.
- The `NodeOrToken::Token(_) => None` arm could be simplified by using a wildcard match arm (e.g., `_ => None`) if there are no other variants to handle, making the match slightly more concise.

## Individual Comments

### Comment 1
<location path="src/parser/ast/mod.rs" line_range="37" />
<code_context>
-                }
-            }
-            NodeOrToken::Token(_) => {}
+    syntax.children_with_tokens().find_map(|child| match child {
+        NodeOrToken::Token(token)
+            if token.kind() == SyntaxKind::T_IDENT && token.text() == name =>
</code_context>
<issue_to_address>
**suggestion (review_instructions):** This new `match` expression has three branches and should be extracted into a separate predicate/helper function to comply with the conditional branching guideline.

The closure passed to `find_map` contains a `match` with three arms. Per the instruction to move conditionals with more than two branches into a predicate function, consider extracting this logic into a small helper (e.g. `fn identifier_span_for_child(...) -> Option<Span>`), and then call that from `find_map` instead of inlining the full `match` here. That keeps the branching logic isolated and the main function simpler.

<details>
<summary>Review instructions:</summary>

**Path patterns:** `**/*.rs`

**Instructions:**
Move conditionals with >2 branches into a predicate function.

</details>
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion (review_instructions): This new match expression has three branches and should be extracted into a separate predicate/helper function to comply with the conditional branching guideline.

The closure passed to find_map contains a match with three arms. Per the instruction to move conditionals with more than two branches into a predicate function, consider extracting this logic into a small helper (e.g. fn identifier_span_for_child(...) -> Option<Span>), and then call that from find_map instead of inlining the full match here. That keeps the branching logic isolated and the main function simpler.

Review instructions:

Path patterns: **/*.rs

Instructions:
Move conditionals with >2 branches into a predicate function.