Consolidate repository-cloning validation: trust API-layer types in the engine

[coderabbitai]

Background

clone_repository_into_workspace in src/engine/connection/repository_clone/mod.rs re-validates repository owner/name segments, branch format, and workspace path — all invariants already enforced by RepositoryRef::parse, BranchName::parse, and WorkspacePath::parse in the API layer.

When callers pass pre-validated types, the engine validation is redundant. When callers construct RepositoryCloneRequest directly (which is possible since all fields are pub), the engine validation acts as defence in depth.

Required action

Decide on and document the validation strategy:

• Option A: Accept only pre-validated value objects in the engine (remove raw-string fields from RepositoryCloneRequest, replace with &RepositoryRef, &BranchName, &WorkspacePath). Remove engine-layer validators.
• Option B: Keep both layers; document that the engine acts as a defence-in-depth guard. Remove the perceived duplication concern from CodeScene by adding an explanatory comment.

References

• PR Repository cloning (4.2.1) #80 (repository cloning — 4.2.1): Repository cloning (4.2.1) #80

[coderabbitai]

🔗 Related PRs

leynos/netsuke#302 - Overhaul Netsuke CLI documentation contract [merged]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

• Create Plan

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!