Background
PR #99 adds InstallationAccessToken with TokenAcquisitionFailed error messages,
log_timing structured output, and a manual Debug impl that redacts the token field.
These are currently verified with brittle substring assertions.
Work required
- Add
insta to dev-dependencies in Cargo.toml if not already present.
- Add snapshot tests in
src/github/installation_token_tests.rs (or a dedicated snapshot
test file) covering:
- Each
GitHubError::TokenAcquisitionFailed message string produced by
InstallationAccessToken::new, from_metadata, and classify_token_error.
- The
Debug formatting of InstallationAccessToken (redaction check).
- The structured fields emitted by
log_timing (use tracing-subscriber/tracing-test
or insta JSON snapshots of captured log events).
- Run
cargo insta review to accept baseline snapshots.
References
Background
PR #99 adds
InstallationAccessTokenwithTokenAcquisitionFailederror messages,log_timingstructured output, and a manualDebugimpl that redacts the token field.These are currently verified with brittle substring assertions.
Work required
instato dev-dependencies inCargo.tomlif not already present.src/github/installation_token_tests.rs(or a dedicated snapshottest file) covering:
GitHubError::TokenAcquisitionFailedmessage string produced byInstallationAccessToken::new,from_metadata, andclassify_token_error.Debugformatting ofInstallationAccessToken(redaction check).log_timing(usetracing-subscriber/tracing-testor
instaJSON snapshots of captured log events).cargo insta reviewto accept baseline snapshots.References