From e85e5a3d31b97714d0bf8c9eb1464710f48f61e4 Mon Sep 17 00:00:00 2001 From: leynos Date: Fri, 24 Jul 2026 20:13:37 +0200 Subject: [PATCH] Allow no_expect_outside_tests pending whitaker#311 Whitaker rolling suite build 4e8a8ab (from leynos/whitaker commit 4e8a8ab6, PR #238) regressed the #[cfg(test)] companion-module exemption in no_expect_outside_tests: expect() calls inside helper and fixture functions under src/**/tests/ are now flagged as "outside test-only code" even though the enclosing module is declared #[cfg(test)]. The previous suite build (2bc0c3f, v0.2.7) linted the same code clean, and the rolling release no longer serves older artefacts, so every CI run now fails the lint gate with 22 false positives. Allow the single affected lint in the Whitaker invocation until leynos/whitaker#311 is fixed, keeping the rest of the suite and Clippy denying warnings as before. A TODO beside the flag records the revert condition. --- Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 8ef66e4..d719fc3 100644 --- a/Makefile +++ b/Makefile @@ -50,7 +50,11 @@ target/%/$(TARGET): ## Build binary in debug or release mode lint: ## Run Clippy and the Whitaker Dylint suite with warnings denied RUSTDOCFLAGS="$(RUSTDOC_FLAGS)" $(CARGO) doc --no-deps $(CARGO) clippy $(CLIPPY_FLAGS) - RUSTFLAGS="$(RUST_FLAGS)" $(WHITAKER) --all -- $(CARGO_FLAGS) +# TODO: drop -A no_expect_outside_tests once leynos/whitaker#311 is fixed: +# rolling suite build 4e8a8ab regressed the #[cfg(test)] companion-module +# exemption and flags expect() calls in test-only helper functions under +# src/**/tests/. + RUSTFLAGS="$(RUST_FLAGS) -A no_expect_outside_tests" $(WHITAKER) --all -- $(CARGO_FLAGS) typecheck: ## Type-check the workspace RUSTFLAGS="$(RUST_FLAGS)" $(CARGO) check $(CARGO_FLAGS) $(BUILD_JOBS)