test: add unit tests for act refactor test-helper functions

[coderabbitai]

Background

PR #127 (Remove refactor helper dead-code witnesses) introduced shared test helpers in crates/weaverd/src/dispatch/act/refactor/refactor_helpers.rs but added only lint-compliance meta-tests. The helper functions themselves have no dedicated unit or behavioural tests.

Required work

Add unit tests (inside a #[cfg(test)] block within refactor_helpers.rs or as a dedicated integration test) that cover the following:

• builders::command_request — verifies domain, operation, and argument fields are set correctly.
• builders::build_backends — verifies the returned backends are constructed without panicking.
• builders::configure_request — verifies in-place mutation replaces all fields.
• content::classify_file — covers .py, .rs, and an unrecognised extension.
• content::original_content_for / updated_content_for — spot-checks known values per file kind.
• content::routed_patch_path — verifies routing for Python, Rust, and Other kinds.
• content::routed_diff_for / routed_malformed_diff_for — verifies well-formed vs malformed diff headers.
• resolutions::rejected_candidate — verifies fields are populated correctly.
• resolutions::resolve_auto_language — covers the Some (selected) and None (refused) branches.

Context

Raised during review of PR #127 by @coderabbitai.
Requested by @leynos.

[coderabbitai]

🔗 Related PRs

leynos/axinite#176 - Persist canonical skill roots in the loaded skill model (1.3.3) [merged]
leynos/stilyagi#11 - Assemble representative fixtures (1.3.1) [merged]
leynos/df12-documentation-skills#4 - Roadmap and Verification Refinements [merged]
leynos/rstest-bdd#488 - Extend first-party policy hint resolution (9.7.1) [merged]
leynos/tei-rapporteur#69 - Bump quick-xml to 0.40.0 [merged]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[leynos]

@CodeRabbit plan

[coderabbitai]

Coding Plan

Summary

• Place tests inside #[cfg(test)] blocks within each sub-module file, following standard Rust testing conventions.
• Use direct field access on pub(crate) structs and the details() accessor on CapabilityResolutionEnvelope.
• Keep tests minimal and targeted, covering only the functions specified in the ticket without introducing new abstractions or refactoring existing code.

Implementation Steps

Add Unit Tests for Refactor Helper Sub-modules

Add #[cfg(test)] blocks to each sub-module file, following Rust convention of co-locating tests with the code under test. Each test module imports only what is necessary and uses direct field access or accessor methods as appropriate.

Task 1: Add tests for `builders` module

Verify the three public functions produce correctly structured outputs.

• Add a #[cfg(test)] mod tests block at the bottom of crates/weaverd/src/dispatch/act/refactor/refactor_helpers/builders.rs
• Test command_request: assert command.domain == "act", command.operation == "refactor", and arguments matches the input vector; confirm patch is None
• Test build_backends: invoke with a temporary directory path and assert the call completes without panicking (a smoke test)
• Test configure_request: create an initial CommandRequest with one set of arguments, call configure_request with different arguments, then assert the struct fields have been wholly replaced

Task 2: Add tests for `content` module

Cover classification logic, fixture content retrieval, and diff formatting.

• Add a #[cfg(test)] mod tests block at the bottom of crates/weaverd/src/dispatch/act/refactor/refactor_helpers/content.rs
• Test classify_file: assert Path::new("foo.py") yields FileKind::Python, Path::new("bar.rs") yields FileKind::Rust, and Path::new("baz.txt") yields FileKind::Other
• Test original_content_for and updated_content_for: spot-check that a .py path returns the Python fixture strings ("old_name = 1\nprint(old_name)\n" and "woven = 1\nprint(woven)\n" respectively); add analogous checks for .rs and a generic extension
• Test routed_patch_path: assert .py and .rs paths both return Path::new("notes.txt"), whilst an unrecognised extension returns the original path unchanged
• Test routed_diff_for: assert the returned string contains the well-formed header diff --git a/notes.txt b/notes.txt for a .py input
• Test routed_malformed_diff_for: assert the returned string contains the malformed header diff --git a/notes.txt (lacking the b/ portion) for a .py input

Task 3: Add tests for `resolutions` module

Verify helper functions construct resolution envelopes with correct field values.

• Add a #[cfg(test)] mod tests block at the bottom of crates/weaverd/src/dispatch/act/refactor/refactor_helpers/resolutions.rs
• Test rejected_candidate: invoke with a provider name and a CandidateReason variant, then assert the returned CandidateEvaluation has accepted == false, the correct provider, and the supplied reason
• Test resolve_auto_language with language_name = Some("python"): assert the envelope's details().outcome is ResolutionOutcome::Selected and details().language is Some("python".into())
• Test resolve_auto_language with language_name = None: assert the envelope's details().outcome is ResolutionOutcome::Refused and details().refusal_reason is Some(RefusalReason::UnsupportedLanguage)

🤖 Prompt for AI agents

Add `#[cfg(test)]` test blocks to each of the three sub-module files in
`crates/weaverd/src/dispatch/act/refactor/refactor_helpers/`. The goal is to add
targeted unit tests for the public helper functions in `builders.rs`,
`content.rs`, and `resolutions.rs`.

**`builders.rs`** — append a `#[cfg(test)] mod tests` block at the bottom of the
file:
- Test `command_request`:
  - Assert `command.domain == "act"` and `command.operation == "refactor"`
  - Assert `arguments` matches the input vector
  - Assert `patch` is `None`
- Test `build_backends`:
  - Invoke with a temporary directory path
  - Assert the call completes without panicking (smoke test only)
- Test `configure_request`:
  - Create an initial `CommandRequest` with one set of arguments
  - Call `configure_request` with different arguments
  - Assert the struct fields have been wholly replaced

**`content.rs`** — append a `#[cfg(test)] mod tests` block at the bottom of the
file:
- Test `classify_file`:
  - `Path::new("foo.py")` → `FileKind::Python`
  - `Path::new("bar.rs")` → `FileKind::Rust`
  - `Path::new("baz.txt")` → `FileKind::Other`
- Test `original_content_for` and `updated_content_for`:
- For a `.py` path, assert `original_content_for` returns `"old_name =
1\nprint(old_name)\n"` and `updated_content_for` returns `"woven =
1\nprint(woven)\n"`
  - Add analogous checks for `.rs` and a generic extension
- Test `routed_patch_path`:
  - `.py` and `.rs` paths both return `Path::new("notes.txt")`
  - An unrecognised extension returns the original path unchanged
- Test `routed_diff_for`:
- For a `.py` input, assert the returned string contains `diff --git a/notes.txt
b/notes.txt`
- Test `routed_malformed_diff_for`:
- For a `.py` input, assert the returned string contains `diff --git
a/notes.txt` (without the `b/` portion)

**`resolutions.rs`** — append a `#[cfg(test)] mod tests` block at the bottom of
the file:
- Test `rejected_candidate`:
  - Invoke with a provider name and a `CandidateReason` variant
- Assert `accepted == false`, the correct `provider`, and the supplied `reason`
- Test `resolve_auto_language` with `language_name = Some("python")`:
  - Assert `details().outcome` is `ResolutionOutcome::Selected`
  - Assert `details().language` is `Some("python".into())`
- Test `resolve_auto_language` with `language_name = None`:
  - Assert `details().outcome` is `ResolutionOutcome::Refused`
- Assert `details().refusal_reason` is
`Some(RefusalReason::UnsupportedLanguage)`

Import only what each test module requires. Use direct field access on
`pub(crate)` structs and the `details()` accessor on
`CapabilityResolutionEnvelope`. Do not introduce new abstractions or refactor
existing code.

Research

The refactor_helpers.rs file in crates/weaverd/src/dispatch/act/refactor/ is a thin module router that declares four sub-modules via #[path = ...] attributes: builders.rs, content.rs, resolutions.rs, and rollback.rs. These sub-modules provide synthetic request builders, fixture content, and resolution envelope factories used by the refactor behaviour tests. The CapabilityResolutionEnvelope struct exposes a details() accessor, and CapabilityResolutionDetails has all fields as pub(crate), permitting direct field access in test assertions.

---

🚀 Next Steps

🤖 All AI agent prompts combined

Add `#[cfg(test)]` test blocks to each of the three sub-module files in
`crates/weaverd/src/dispatch/act/refactor/refactor_helpers/`. The goal is to add
targeted unit tests for the public helper functions in `builders.rs`,
`content.rs`, and `resolutions.rs`.

**`builders.rs`** — append a `#[cfg(test)] mod tests` block at the bottom of the
file:
- Test `command_request`:
  - Assert `command.domain == "act"` and `command.operation == "refactor"`
  - Assert `arguments` matches the input vector
  - Assert `patch` is `None`
- Test `build_backends`:
  - Invoke with a temporary directory path
  - Assert the call completes without panicking (smoke test only)
- Test `configure_request`:
  - Create an initial `CommandRequest` with one set of arguments
  - Call `configure_request` with different arguments
  - Assert the struct fields have been wholly replaced

**`content.rs`** — append a `#[cfg(test)] mod tests` block at the bottom of the
file:
- Test `classify_file`:
  - `Path::new("foo.py")` → `FileKind::Python`
  - `Path::new("bar.rs")` → `FileKind::Rust`
  - `Path::new("baz.txt")` → `FileKind::Other`
- Test `original_content_for` and `updated_content_for`:
- For a `.py` path, assert `original_content_for` returns `"old_name =
1\nprint(old_name)\n"` and `updated_content_for` returns `"woven =
1\nprint(woven)\n"`
  - Add analogous checks for `.rs` and a generic extension
- Test `routed_patch_path`:
  - `.py` and `.rs` paths both return `Path::new("notes.txt")`
  - An unrecognised extension returns the original path unchanged
- Test `routed_diff_for`:
- For a `.py` input, assert the returned string contains `diff --git a/notes.txt
b/notes.txt`
- Test `routed_malformed_diff_for`:
- For a `.py` input, assert the returned string contains `diff --git
a/notes.txt` (without the `b/` portion)

**`resolutions.rs`** — append a `#[cfg(test)] mod tests` block at the bottom of
the file:
- Test `rejected_candidate`:
  - Invoke with a provider name and a `CandidateReason` variant
- Assert `accepted == false`, the correct `provider`, and the supplied `reason`
- Test `resolve_auto_language` with `language_name = Some("python")`:
  - Assert `details().outcome` is `ResolutionOutcome::Selected`
  - Assert `details().language` is `Some("python".into())`
- Test `resolve_auto_language` with `language_name = None`:
  - Assert `details().outcome` is `ResolutionOutcome::Refused`
- Assert `details().refusal_reason` is
`Some(RefusalReason::UnsupportedLanguage)`

Import only what each test module requires. Use direct field access on
`pub(crate)` structs and the `details()` accessor on
`CapabilityResolutionEnvelope`. Do not introduce new abstractions or refactor
existing code.

💡 Iterate on the plan with: `@coderabbitai` <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For design choice 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!