Refactor: remove runtime_dir from LifecycleError domain error variants

[coderabbitai]

Background

Identified during code review of #128 (Define local daemon observability).

LifecycleError::LaunchDaemon and LifecycleError::StartupFailed in crates/weaver-cli/src/lifecycle/error.rs both carry a runtime_dir: PathBuf field. This field is used exclusively by the CLI guidance layer (crates/weaver-cli/src/actionable_guidance.rs) to derive the weaverd.health path and surface it in actionable alternatives.

Injecting a filesystem path into a domain error type for the benefit of an adapter (the CLI output layer) violates the domain/adapter boundary.

Proposed direction

Remove runtime_dir from LifecycleError::LaunchDaemon and LifecycleError::StartupFailed. Thread the runtime directory separately through the CLI layer's context so that actionable_guidance.rs can derive the health-snapshot path without requiring the domain error to carry infrastructure-specific state.

Affected files

• crates/weaver-cli/src/lifecycle/error.rs
• crates/weaver-cli/src/lifecycle/spawning.rs
• crates/weaver-cli/src/lifecycle/monitoring.rs
• crates/weaver-cli/src/actionable_guidance.rs
• crates/weaver-cli/src/tests/unit/actionable_guidance.rs

References

• PR: Define local daemon observability (#122) #128
• Flagged by CodeScene Domain Architecture check during review of Define local daemon observability (#122) #128
• Raised by @leynos

[coderabbitai]

🔗 Related PRs

#131 - Extend daemon start help with config and environment guidance (3.2.2) [merged]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

• Create Plan

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!