Associate eps with their levels

[edelkas]

It might be interesting to associate them with has_many and belongs_to relationships to access them quicker and cleaner, as opposed to the verbose SQL command that is now being used. Though this might involve a tedious rebuilding of the database.

[liam-mitchell]

Which verbose SQL command are you mentioning? I certainly don't think this is a bad idea, it completely makes sense and I don't doubt I've done some weird SQL stuff in here somewhere - just can't find the query you're referring to :)

It's not a huge deal to add a relationship like that to the DB, there's a quick-and-dirty guide to adding has_many on SO here if you'd like to take a stab at it: https://stackoverflow.com/questions/31450381/has-many-association-migration-in-rails/31450705

You can look into the documentation on DB migrations here if you'd like to learn a bit more about how modifying the database schema works in ActiveRecord (the DB library I use for inne): https://guides.rubyonrails.org/v3.2/migrations.html

[edelkas]

Maybe I didn't use the correct term to describe it, but this is the line I'm referring to:

inne/messages.rb

Lines 206 to 208 in 28619f6

	if scores.is_a?(Episode)
	Level.where("UPPER(name) LIKE ?", scores.name.upcase + '%').each(&:download_scores)
	end

When inne is asked for episode scores, which I've had to reuse a few times now for episode cleanliness and episode ownages. I'll check out those links and look into adding those relations to simplify that line to something like
scores.levels.each(&:download_scores)
which could also be useful in other situations.

[liam-mitchell]

Oh, yeah, I see what you mean. For sure, I agree that would be way cleaner, and it makes semantic sense for the levels to 'belong to' an episode.

[edelkas]

Late update for anyone following progress in this fork:
Addressed in edelkas@8965269 on 27 Nov 2020