Fix lints

Author: alan-george-lk

src/data_track_stream.cpp

@@ -62,7 +62,7 @@ bool DataTrackStream::read(DataTrackFrame &out) {
     return false;
   }
 
-  out = std::move(*frame_);
+  out = std::move(*frame_); // NOLINT(bugprone-unchecked-optional-access)
   frame_.reset();
   return true;
 }

src/logging.cpp

@@ -61,9 +61,9 @@ LogLevel fromSpdlogLevel(spdlog::level::level_enum level) {
     return LogLevel::Error;
   case spdlog::level::critical:
     return LogLevel::Critical;
-  case spdlog::level::off:
+  case spdlog::level::off: // NOLINT(bugprone-branch-clone)
     return LogLevel::Off;
-  default: // NOLINT(bugprone-branch-clone)
+  default:
     return LogLevel::Info;
   }
 }

src/room_event_converter.cpp

@@ -54,9 +54,9 @@ DataPacketKind toDataPacketKind(proto::DataPacketKind src) {
   switch (src) {
   case proto::KIND_LOSSY:
     return DataPacketKind::Lossy;
-  case proto::KIND_RELIABLE:
+  case proto::KIND_RELIABLE: // NOLINT(bugprone-branch-clone)
     return DataPacketKind::Reliable;
-  default: // NOLINT(bugprone-branch-clone)
+  default:
     return DataPacketKind::Reliable;
   }
 }

src/room_proto_converter.cpp

@@ -56,9 +56,9 @@ DataPacketKind toDataPacketKind(proto::DataPacketKind in) {
   switch (in) {
   case proto::KIND_LOSSY:
     return DataPacketKind::Lossy;
-  case proto::KIND_RELIABLE:
+  case proto::KIND_RELIABLE: // NOLINT(bugprone-branch-clone)
     return DataPacketKind::Reliable;
-  default: // NOLINT(bugprone-branch-clone)
+  default:
     return DataPacketKind::Reliable;
   }
 }

src/stats.cpp

@@ -49,9 +49,9 @@ QualityLimitationReason fromProto(livekit::proto::QualityLimitationReason r) {
     return QualityLimitationReason::Cpu;
   case P::LIMITATION_BANDWIDTH:
     return QualityLimitationReason::Bandwidth;
-  case P::LIMITATION_OTHER:
+  case P::LIMITATION_OTHER: // NOLINT(bugprone-branch-clone)
     return QualityLimitationReason::Other;
-  default: // NOLINT(bugprone-branch-clone)
+  default:
     return QualityLimitationReason::Other;
   }
 }

src/track_proto_converter.cpp

@@ -55,9 +55,9 @@ TrackKind fromProto(proto::TrackKind in) {
     return TrackKind::KIND_AUDIO;
   case proto::TrackKind::KIND_VIDEO:
     return TrackKind::KIND_VIDEO;
-  case proto::TrackKind::KIND_UNKNOWN:
+  case proto::TrackKind::KIND_UNKNOWN: // NOLINT(bugprone-branch-clone)
     return TrackKind::KIND_UNKNOWN;
-  default: // NOLINT(bugprone-branch-clone)
+  default:
     return TrackKind::KIND_UNKNOWN;
   }
 }
@@ -68,9 +68,9 @@ StreamState fromProto(proto::StreamState in) {
     return StreamState::STATE_ACTIVE;
   case proto::StreamState::STATE_PAUSED:
     return StreamState::STATE_PAUSED;
-  case proto::StreamState::STATE_UNKNOWN:
+  case proto::StreamState::STATE_UNKNOWN: // NOLINT(bugprone-branch-clone)
     return StreamState::STATE_UNKNOWN;
-  default: // NOLINT(bugprone-branch-clone)
+  default:
     return StreamState::STATE_UNKNOWN;
   }
 }
@@ -85,9 +85,9 @@ TrackSource fromProto(proto::TrackSource in) {
     return TrackSource::SOURCE_SCREENSHARE;
   case proto::TrackSource::SOURCE_SCREENSHARE_AUDIO:
     return TrackSource::SOURCE_SCREENSHARE_AUDIO;
-  case proto::TrackSource::SOURCE_UNKNOWN:
+  case proto::TrackSource::SOURCE_UNKNOWN: // NOLINT(bugprone-branch-clone)
     return TrackSource::SOURCE_UNKNOWN;
-  default: // NOLINT(bugprone-branch-clone)
+  default:
     return TrackSource::SOURCE_UNKNOWN;
   }
 }