Additional clang-tidy fixes, 0 warning threshold

Author: alan-george-lk

.clang-tidy

@@ -8,6 +8,7 @@ Checks: >
   -bugprone-easily-swappable-parameters,
   -modernize-use-trailing-return-type,
   -modernize-avoid-c-arrays,
+  -modernize-use-auto,
   -modernize-use-nodiscard,
   -performance-enum-size,
   -readability-braces-around-statements,

.github/workflows/builds.yml

@@ -669,7 +669,7 @@ jobs:
       - name: Check warning thresholds
         env:
           TIDY_FINDINGS: ${{ steps.linter.outputs.clang-tidy-checks-failed }}
-          MAX_TIDY_FINDINGS: '396'
+          MAX_TIDY_FINDINGS: '0'
         run: |
           echo "clang-tidy findings: ${TIDY_FINDINGS}"
           if [ "${TIDY_FINDINGS}" -gt "${MAX_TIDY_FINDINGS}" ]; then

src/audio_frame.cpp

@@ -68,7 +68,7 @@ AudioFrame::fromOwnedInfo(const proto::OwnedAudioFrameBuffer &owned) {
   const std::size_t count = static_cast<std::size_t>(num_channels) *
                             static_cast<std::size_t>(samples_per_channel);
 
-  const auto *ptr =
+  const std::int16_t *ptr =
       reinterpret_cast<const std::int16_t *>(info.data_ptr()); // NOLINT(performance-no-int-to-ptr)
 
   if (ptr == nullptr && count > 0) {

src/room_proto_converter.cpp

@@ -57,7 +57,6 @@ DataPacketKind toDataPacketKind(proto::DataPacketKind in) {
   case proto::KIND_LOSSY:
     return DataPacketKind::Lossy;
   case proto::KIND_RELIABLE:
-    return DataPacketKind::Reliable;
   default:
     return DataPacketKind::Reliable;
   }
@@ -74,7 +73,7 @@ UserPacketData fromProto(const proto::UserPacket &in) {
   UserPacketData out;
   // TODO, double check following code is safe
   const auto &buf = in.data().data();
-  auto ptr = reinterpret_cast<const std::uint8_t *>(buf.data_ptr());
+  auto ptr = reinterpret_cast<const std::uint8_t *>(buf.data_ptr()); // NOLINT(performance-no-int-to-ptr)
   auto len = static_cast<std::size_t>(buf.data_len());
   out.data.assign(ptr, ptr + len);
   if (in.has_topic()) {
@@ -386,7 +385,7 @@ UserDataPacketEvent userDataPacketFromProto(const proto::DataPacketReceived &in,
   const auto &owned = in.user().data();
   const auto &info = owned.data();
   if (info.data_ptr() != 0 && info.data_len() > 0) {
-    auto ptr = reinterpret_cast<const std::uint8_t *>(info.data_ptr());
+    auto ptr = reinterpret_cast<const std::uint8_t *>(info.data_ptr()); // NOLINT(performance-no-int-to-ptr)
     auto len = static_cast<std::size_t>(info.data_len());
     ev.data.assign(ptr, ptr + len);
   } else {

src/video_frame.cpp

@@ -46,11 +46,8 @@ std::size_t computeBufferSize(int width, int height, VideoBufferType type) {
     return w * h * 4;
 
   case VideoBufferType::RGB24:
-    // 3 bytes per pixel
-    return w * h * 3;
-
   case VideoBufferType::I444:
-    // Y, U, V all full resolution
+    // 3 bytes per pixel (RGB24: packed; I444: Y+U+V all full resolution)
     return w * h * 3;
 
   case VideoBufferType::I420:
@@ -295,7 +292,7 @@ VideoFrame::VideoFrame(int width, int height, VideoBufferType type,
 VideoFrame VideoFrame::create(int width, int height, VideoBufferType type) {
   const std::size_t size = computeBufferSize(width, height, type);
   std::vector<std::uint8_t> buffer(size, 0);
-  return VideoFrame(width, height, type, std::move(buffer));
+  return {width, height, type, std::move(buffer)};
 }
 
 std::vector<VideoPlaneInfo> VideoFrame::planeInfos() const {
@@ -315,7 +312,7 @@ VideoFrame VideoFrame::convert(VideoBufferType dst, bool flip_y) const {
     LK_LOG_WARN("VideoFrame::convert: converting to the same format");
     // copy pixel data
     std::vector<std::uint8_t> buf = data_;
-    return VideoFrame(width_, height_, type_, std::move(buf));
+    return {width_, height_, type_, std::move(buf)};
   }
 
   // General path: delegate to the FFI-based conversion helper.
@@ -342,15 +339,15 @@ VideoFrame VideoFrame::fromOwnedInfo(const proto::OwnedVideoBuffer &owned) {
     std::size_t offset = 0;
     for (const auto &comp : info.components()) {
       const auto sz = static_cast<std::size_t>(comp.size());
-      const auto src_ptr = reinterpret_cast<const std::uint8_t *>(
+      const auto src_ptr = reinterpret_cast<const std::uint8_t *>( // NOLINT(performance-no-int-to-ptr)
           static_cast<std::uintptr_t>(comp.data_ptr()));
 
       std::memcpy(buffer.data() + offset, src_ptr, sz);
       offset += sz;
     }
   } else {
     // Packed format: treat top-level data_ptr as a single contiguous buffer.
-    const auto src_ptr = reinterpret_cast<const std::uint8_t *>(
+    const auto src_ptr = reinterpret_cast<const std::uint8_t *>( // NOLINT(performance-no-int-to-ptr)
         static_cast<std::uintptr_t>(info.data_ptr()));
 
     std::size_t total_size = 0;
@@ -373,7 +370,7 @@ VideoFrame VideoFrame::fromOwnedInfo(const proto::OwnedVideoBuffer &owned) {
     // owned_handle destroyed at end of scope → native buffer disposed.
   }
 
-  return VideoFrame(width, height, type, std::move(buffer));
+  return {width, height, type, std::move(buffer)};
 }
 
 } // namespace livekit