@@ -547,11 +547,13 @@ jobs:
547547 cmake --build build --parallel
548548 '
549549
550- # Lightweight job: configure-only to produce compile_commands.json + generated
551- # protobuf headers for clang-tidy, without waiting for the full build.
552- configure :
553- name : Configure (compile database)
550+ clang-tidy :
551+ name : clang-tidy
554552 runs-on : ubuntu-latest
553+ continue-on-error : false
554+ permissions :
555+ contents : read
556+ pull-requests : write
555557
556558 steps :
557559 - name : Checkout (with submodules)
@@ -560,13 +562,13 @@ jobs:
560562 submodules : recursive
561563 fetch-depth : 1
562564
563- - name : Install deps (Ubuntu)
565+ - name : Install dependencies
564566 run : |
565567 set -eux
566568 sudo apt-get update
567569 sudo apt-get install -y \
568570 build-essential cmake ninja-build pkg-config \
569- llvm-dev libclang-dev clang \
571+ llvm-dev libclang-dev clang clang-tidy \
570572 libva-dev libdrm-dev libgbm-dev libx11-dev libgl1-mesa-dev \
571573 libxext-dev libxcomposite-dev libxdamage-dev libxfixes-dev \
572574 libxrandr-dev libxi-dev libxkbcommon-dev \
@@ -595,56 +597,6 @@ jobs:
595597 - name : Generate protobuf headers
596598 run : cmake --build build-release --target livekit_proto
597599
598- - name : Upload compile database
599- uses : actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
600- with :
601- name : compile-database
602- path : |
603- build-release/compile_commands.json
604- build-release/generated/
605- build-release/_deps/*-src/
606- include/livekit/build.h
607- retention-days : 1
608-
609- clang-tidy :
610- name : clang-tidy
611- needs : configure
612- runs-on : ubuntu-latest
613- continue-on-error : false
614- if : ${{ !cancelled() }}
615- permissions :
616- contents : read
617- pull-requests : write
618-
619- steps :
620- - name : Checkout (with submodules)
621- uses : actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
622- with :
623- submodules : recursive
624- fetch-depth : 1
625-
626- - name : Install dependencies
627- run : |
628- set -eux
629- sudo apt-get update
630- sudo apt-get install -y \
631- clang-tidy \
632- llvm-dev libclang-dev clang \
633- libssl-dev \
634- libprotobuf-dev protobuf-compiler \
635- libabsl-dev \
636- libspdlog-dev \
637- libva-dev libdrm-dev libgbm-dev libx11-dev libgl1-mesa-dev \
638- libxext-dev libxcomposite-dev libxdamage-dev libxfixes-dev \
639- libxrandr-dev libxi-dev libxkbcommon-dev \
640- libasound2-dev libpulse-dev \
641- libwayland-dev libdecor-0-dev
642-
643- - name : Download compile database
644- uses : actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
645- with :
646- name : compile-database
647-
648600 - name : Run clang-tidy
649601 uses : cpp-linter/cpp-linter-action@77c390c5ba9c947ebc185a3e49cc754f1558abb5 # v2.18.0
650602 id : linter
@@ -664,7 +616,7 @@ jobs:
664616 tidy-review : true
665617 passive-reviews : true
666618 no-lgtm : true
667- jobs : 0 # use all available CPU cores
619+ jobs : 0 # 0 == use all available CPU cores
668620
669621 - name : Check warning thresholds
670622 env :
0 commit comments