Skip to content

Commit 8bbcc07

Browse files
fix the rebase problem
1 parent a0fe327 commit 8bbcc07

1 file changed

Lines changed: 4 additions & 26 deletions

File tree

src/tests/CMakeLists.txt

Lines changed: 4 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ set(BENCHMARK_UTILS_SOURCES
3636
# ============================================================================
3737
# Unit Tests
3838
# ============================================================================
39+
40+
# Collect all unit test sources
3941
file(GLOB UNIT_TEST_SOURCES
4042
"${CMAKE_CURRENT_SOURCE_DIR}/unit/*.cpp"
4143
)
@@ -49,7 +51,6 @@ if(UNIT_TEST_SOURCES)
4951
target_link_libraries(livekit_unit_tests
5052
PRIVATE
5153
livekit
52-
spdlog::spdlog
5354
GTest::gtest_main
5455
GTest::gmock
5556
)
@@ -58,19 +59,15 @@ if(UNIT_TEST_SOURCES)
5859
PRIVATE
5960
${LIVEKIT_ROOT_DIR}/include
6061
${LIVEKIT_ROOT_DIR}/src
61-
${LIVEKIT_ROOT_DIR}/src/trace
6262
${CMAKE_CURRENT_SOURCE_DIR}/benchmark
6363
)
6464

65-
# Copy shared libraries to test executable directory
6665
target_compile_definitions(livekit_unit_tests
6766
PRIVATE
68-
LIVEKIT_TEST_ACCESS
6967
LIVEKIT_ROOT_DIR="${LIVEKIT_ROOT_DIR}"
70-
SPDLOG_ACTIVE_LEVEL=${_SPDLOG_ACTIVE_LEVEL}
71-
$<$<PLATFORM_ID:Windows>:_USE_MATH_DEFINES>
7268
)
7369

70+
# Copy shared libraries to test executable directory
7471
if(WIN32)
7572
add_custom_command(TARGET livekit_unit_tests POST_BUILD
7673
COMMAND ${CMAKE_COMMAND} -E copy_if_different
@@ -103,10 +100,9 @@ if(UNIT_TEST_SOURCES)
103100
)
104101
endif()
105102

106-
103+
# Register tests with CTest
107104
gtest_discover_tests(livekit_unit_tests
108105
WORKING_DIRECTORY ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}
109-
DISCOVERY_MODE PRE_TEST
110106
PROPERTIES
111107
LABELS "unit"
112108
)
@@ -127,18 +123,10 @@ if(INTEGRATION_TEST_SOURCES)
127123
${BENCHMARK_UTILS_SOURCES}
128124
)
129125

130-
# On Windows, protobuf default-instance symbols (constinit globals) are not
131-
# auto-exported from livekit.dll by WINDOWS_EXPORT_ALL_SYMBOLS. Link the
132-
# proto object library directly so the test binary has its own copy.
133-
if(WIN32 AND TARGET livekit_proto)
134-
target_sources(livekit_integration_tests PRIVATE $<TARGET_OBJECTS:livekit_proto>)
135-
endif()
136-
137126
target_link_libraries(livekit_integration_tests
138127
PRIVATE
139128
livekit
140129
spdlog::spdlog
141-
$<$<PLATFORM_ID:Windows>:${LIVEKIT_PROTOBUF_TARGET}>
142130
GTest::gtest_main
143131
GTest::gmock
144132
)
@@ -147,7 +135,6 @@ if(INTEGRATION_TEST_SOURCES)
147135
PRIVATE
148136
${LIVEKIT_ROOT_DIR}/include
149137
${LIVEKIT_ROOT_DIR}/src
150-
${LIVEKIT_ROOT_DIR}/src/trace
151138
${CMAKE_CURRENT_SOURCE_DIR}/benchmark
152139
${LIVEKIT_BINARY_DIR}/generated
153140
${Protobuf_INCLUDE_DIRS}
@@ -166,7 +153,6 @@ if(INTEGRATION_TEST_SOURCES)
166153
LIVEKIT_TEST_ACCESS
167154
LIVEKIT_ROOT_DIR="${LIVEKIT_ROOT_DIR}"
168155
SPDLOG_ACTIVE_LEVEL=${_SPDLOG_ACTIVE_LEVEL}
169-
$<$<PLATFORM_ID:Windows>:_USE_MATH_DEFINES>
170156
)
171157

172158
# Copy shared libraries to test executable directory
@@ -205,7 +191,6 @@ if(INTEGRATION_TEST_SOURCES)
205191
# Register tests with CTest
206192
gtest_discover_tests(livekit_integration_tests
207193
WORKING_DIRECTORY ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}
208-
DISCOVERY_MODE PRE_TEST
209194
PROPERTIES
210195
LABELS "integration"
211196
)
@@ -237,15 +222,9 @@ if(STRESS_TEST_SOURCES)
237222
PRIVATE
238223
${LIVEKIT_ROOT_DIR}/include
239224
${LIVEKIT_ROOT_DIR}/src
240-
${LIVEKIT_ROOT_DIR}/src/trace
241225
${CMAKE_CURRENT_SOURCE_DIR}/benchmark
242226
)
243227

244-
target_compile_definitions(livekit_stress_tests
245-
PRIVATE
246-
$<$<PLATFORM_ID:Windows>:_USE_MATH_DEFINES>
247-
)
248-
249228
# Copy shared libraries to test executable directory
250229
if(WIN32)
251230
add_custom_command(TARGET livekit_stress_tests POST_BUILD
@@ -282,7 +261,6 @@ if(STRESS_TEST_SOURCES)
282261
# Register tests with CTest (longer timeout for stress tests)
283262
gtest_discover_tests(livekit_stress_tests
284263
WORKING_DIRECTORY ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}
285-
DISCOVERY_MODE PRE_TEST
286264
PROPERTIES
287265
LABELS "stress"
288266
TIMEOUT 300

0 commit comments

Comments
 (0)