Additional clang-tidy changes

Author: alan-george-lk

include/livekit/data_stream.h

@@ -78,7 +78,7 @@ struct ByteStreamInfo : BaseStreamInfo {
 class TextStreamReader {
 public:
   /// Construct a reader from initial stream metadata.
-  explicit TextStreamReader(const TextStreamInfo &info);
+  explicit TextStreamReader(TextStreamInfo info);
 
   TextStreamReader(const TextStreamReader &) = delete;
   TextStreamReader &operator=(const TextStreamReader &) = delete;
@@ -118,7 +118,7 @@ class TextStreamReader {
 class ByteStreamReader {
 public:
   /// Construct a reader from initial stream metadata.
-  explicit ByteStreamReader(const ByteStreamInfo &info);
+  explicit ByteStreamReader(ByteStreamInfo info);
 
   ByteStreamReader(const ByteStreamReader &) = delete;
   ByteStreamReader &operator=(const ByteStreamReader &) = delete;
@@ -177,13 +177,13 @@ class BaseStreamWriter {
 
 protected:
   BaseStreamWriter(LocalParticipant &local_participant,
-                   const std::string &topic = "",
-                   const std::map<std::string, std::string> &attributes = {},
-                   const std::string &stream_id = "",
+                   std::string topic = "",
+                   std::map<std::string, std::string> attributes = {},
+                   std::string stream_id = "",
                    std::optional<std::size_t> total_size = std::nullopt,
-                   const std::string &mime_type = "",
-                   const std::vector<std::string> &destination_identities = {},
-                   const std::string &sender_identity = "");
+                   std::string mime_type = "",
+                   std::vector<std::string> destination_identities = {},
+                   std::string sender_identity = "");
 
   enum class StreamKind { kUnknown, kText, kByte };
 

src/audio_frame.cpp

@@ -54,8 +54,7 @@ AudioFrame AudioFrame::create(int sample_rate, int num_channels,
   const std::size_t count = static_cast<std::size_t>(num_channels) *
                             static_cast<std::size_t>(samples_per_channel);
   std::vector<std::int16_t> data(count, 0);
-  return AudioFrame(std::move(data), sample_rate, num_channels,
-                    samples_per_channel);
+  return {std::move(data), sample_rate, num_channels, samples_per_channel};
 }
 
 AudioFrame
@@ -69,8 +68,8 @@ AudioFrame::fromOwnedInfo(const proto::OwnedAudioFrameBuffer &owned) {
   const std::size_t count = static_cast<std::size_t>(num_channels) *
                             static_cast<std::size_t>(samples_per_channel);
 
-  const std::int16_t *ptr =
-      reinterpret_cast<const std::int16_t *>(info.data_ptr());
+  const auto *ptr =
+      reinterpret_cast<const std::int16_t *>(info.data_ptr()); // NOLINT(performance-no-int-to-ptr)
 
   if (ptr == nullptr && count > 0) {
     throw std::runtime_error(
@@ -88,8 +87,7 @@ AudioFrame::fromOwnedInfo(const proto::OwnedAudioFrameBuffer &owned) {
     // drop the OwnedAudioFrameBuffer.
   }
 
-  return AudioFrame(std::move(data), sample_rate, num_channels,
-                    samples_per_channel);
+  return {std::move(data), sample_rate, num_channels, samples_per_channel};
 }
 
 proto::AudioFrameBufferInfo AudioFrame::toProto() const {

src/data_stream.cpp

@@ -104,7 +104,8 @@ void fillBaseInfo(BaseStreamInfo &dst, const std::string &stream_id,
 // Reader implementation
 // =====================================================================
 
-TextStreamReader::TextStreamReader(const TextStreamInfo &info) : info_(info) {}
+TextStreamReader::TextStreamReader(TextStreamInfo info)
+    : info_(std::move(info)) {}
 
 void TextStreamReader::onChunkUpdate(const std::string &text) {
   {
@@ -148,7 +149,8 @@ std::string TextStreamReader::readAll() {
   return result;
 }
 
-ByteStreamReader::ByteStreamReader(const ByteStreamInfo &info) : info_(info) {}
+ByteStreamReader::ByteStreamReader(ByteStreamInfo info)
+    : info_(std::move(info)) {}
 
 void ByteStreamReader::onChunkUpdate(const std::vector<std::uint8_t> &bytes) {
   {
@@ -189,21 +191,22 @@ bool ByteStreamReader::readNext(std::vector<std::uint8_t> &out) {
 // =====================================================================
 
 BaseStreamWriter::BaseStreamWriter(
-    LocalParticipant &local_participant, const std::string &topic,
-    const std::map<std::string, std::string> &attributes,
-    const std::string &stream_id, std::optional<std::size_t> total_size,
-    const std::string &mime_type,
-    const std::vector<std::string> &destination_identities,
-    const std::string &sender_identity)
+    LocalParticipant &local_participant, std::string topic,
+    std::map<std::string, std::string> attributes,
+    std::string stream_id, std::optional<std::size_t> total_size,
+    std::string mime_type,
+    std::vector<std::string> destination_identities,
+    std::string sender_identity)
     : local_participant_(local_participant),
-      stream_id_(stream_id.empty() ? generateRandomId() : stream_id),
-      mime_type_(mime_type), topic_(topic),
+      stream_id_(stream_id.empty() ? generateRandomId()
+                                   : std::move(stream_id)),
+      mime_type_(std::move(mime_type)), topic_(std::move(topic)),
       timestamp_ms_(std::chrono::duration_cast<std::chrono::milliseconds>(
                         std::chrono::system_clock::now().time_since_epoch())
                         .count()),
-      total_size_(total_size), attributes_(attributes),
-      destination_identities_(destination_identities),
-      sender_identity_(sender_identity) {
+      total_size_(total_size), attributes_(std::move(attributes)),
+      destination_identities_(std::move(destination_identities)),
+      sender_identity_(std::move(sender_identity)) {
   if (sender_identity_.empty()) {
     sender_identity_ = local_participant_.identity();
   }

src/stats.cpp

@@ -50,7 +50,6 @@ QualityLimitationReason fromProto(livekit::proto::QualityLimitationReason r) {
   case P::LIMITATION_BANDWIDTH:
     return QualityLimitationReason::Bandwidth;
   case P::LIMITATION_OTHER:
-    return QualityLimitationReason::Other;
   default:
     return QualityLimitationReason::Other;
   }