diff --git a/.changes/fix-pub-score-static-analysis b/.changes/fix-pub-score-static-analysis new file mode 100644 index 000000000..9fe31246f --- /dev/null +++ b/.changes/fix-pub-score-static-analysis @@ -0,0 +1 @@ +patch type="fixed" "Fix wildcard variable lint warnings to improve pub.dev score" diff --git a/analysis_options.yaml b/analysis_options.yaml index f1291ca50..1694022da 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -18,7 +18,6 @@ include: package:lints/recommended.yaml analyzer: errors: constant_identifier_names: ignore - no_wildcard_variable_uses: ignore use_super_parameters: ignore avoid_print: ignore deprecated_member_use_from_same_package: ignore diff --git a/lib/src/participant/local.dart b/lib/src/participant/local.dart index 2716c703e..5f6a56665 100644 --- a/lib/src/participant/local.dart +++ b/lib/src/participant/local.dart @@ -531,8 +531,8 @@ class LocalParticipant extends Participant { await room.engine.publisher?.pc.removeTrack(simulcastTrack.sender!); }); } - } catch (_) { - logger.warning('[$objectId] rtc.removeTrack() did throw ${_}'); + } catch (e) { + logger.warning('[$objectId] rtc.removeTrack() did throw $e'); } // doesn't make sense to negotiate if already disposed diff --git a/lib/src/support/websocket/io.dart b/lib/src/support/websocket/io.dart index 9448c1ecd..be65c1d86 100644 --- a/lib/src/support/websocket/io.dart +++ b/lib/src/support/websocket/io.dart @@ -65,8 +65,8 @@ class LiveKitWebSocketIO extends LiveKitWebSocket { try { _ws.add(data); - } catch (_) { - logger.fine('[$objectId] send did throw ${_}'); + } catch (e) { + logger.fine('[$objectId] send did throw $e'); } } diff --git a/lib/src/support/websocket/web.dart b/lib/src/support/websocket/web.dart index d00c50256..2be79e57b 100644 --- a/lib/src/support/websocket/web.dart +++ b/lib/src/support/websocket/web.dart @@ -43,13 +43,13 @@ class LiveKitWebSocketWeb extends LiveKitWebSocket { Map? headers, // ignore: unused_element_parameter ]) { _ws.binaryType = 'arraybuffer'; - _messageSubscription = _ws.onMessage.listen((_) { + _messageSubscription = _ws.onMessage.listen((event) { if (isDisposed) { logger.warning('$objectId already disposed, ignoring received data.'); return; } final dynamic data = - _.data.instanceOfString('ArrayBuffer') ? (_.data as JSArrayBuffer).toDart.asUint8List() : _.data; + event.data.instanceOfString('ArrayBuffer') ? (event.data as JSArrayBuffer).toDart.asUint8List() : event.data; options?.onData?.call(data); }); _closeSubscription = _ws.onClose.listen((_) async { diff --git a/lib/src/track/track.dart b/lib/src/track/track.dart index 92dffc66e..520a69169 100644 --- a/lib/src/track/track.dart +++ b/lib/src/track/track.dart @@ -152,8 +152,8 @@ abstract class Track extends DisposableChangeNotifier with EventsEmittable