drop testing against LS 5.x#4
Closed
kares wants to merge 3 commits into
Closed
Conversation
... as its more and more problematic
yaauie
reviewed
Feb 11, 2020
| install: ci/unit/docker-setup.sh | ||
| script: ci/unit/docker-run.sh | ||
| version: ~> 1.0 | ||
| import: logstash-plugins/.ci:unit.travis.yml@master |
Contributor
There was a problem hiding this comment.
🤔
Would it make sense to just import the environment matrix, and to keep the rest of the config in the example? This would allow us to start sharing the matrix even on plugins that need environment-specific install or script params.
Contributor
Author
There was a problem hiding this comment.
not sure I understand, this is just here as a simple example on how to import the unit.travis.yml
one can easily override script/install parts, you would just want to make it clear here, than?
version: ~> 1.0
import: logstash-plugins/.ci:unit.travis.yml@master
install: ci/unit/docker-setup.sh
script: ci/unit/docker-run.sh
Member
|
dropping 5.x has been done in #5 , closing here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also renamed config to
unit.travis.ymlas we will want to import - thus name should be clear: