Skip to content

refactor travis setup#5

Merged
jsvd merged 1 commit into
masterfrom
travis_refactor
Mar 17, 2020
Merged

refactor travis setup#5
jsvd merged 1 commit into
masterfrom
travis_refactor

Conversation

@jsvd

@jsvd jsvd commented Feb 13, 2020

Copy link
Copy Markdown
Member

rely on config imports to maximize reuse. For a plugin to adopt these scripts they only need to either add a simple:

import:
- logstash-plugins/.ci:travis/defaults.yml@travis_refactor
- logstash-plugins/.ci:travis/matrix.yml@travis_refactor
- logstash-plugins/.ci:travis/exec.yml@travis_refactor

This pull request tries to do away with submodules to reduce the effort of adoption. The exec.yml downloads a tarball with all the necessary docker and shell scripts, but skips any existing files, so plugins can customize testing.

The goal is to version the yaml and scripts through git tags, so all plugins rely on the same setup (unless it is customized).

@jsvd jsvd requested review from kares and yaauie February 13, 2020 10:38

@kares kares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like where this is going, esp. since the inception some of my assumptions have aged,
namely: unit/Dockerfile was far fetched - having one shareable Dockerfile should do.
+1 on composable .travis.yml imports - likely easier to reason than merging 2 ymls.

only thing I have doubts is downloading the .ci repo instead of the sub-module check-out.
just from browsing the single repo on GH we won't be able to see all the CI build parts.
willing to give it a try on a few repos and see how we like it compared to a sub-module.

@jsvd jsvd force-pushed the travis_refactor branch from 1703668 to 3a765e8 Compare March 11, 2020 10:34
@jsvd jsvd force-pushed the travis_refactor branch from a280dd9 to 9e71d40 Compare March 11, 2020 16:44
@jsvd

jsvd commented Mar 11, 2020

Copy link
Copy Markdown
Member Author

I have updated the PR to reduce the scope (drop auto publishing).
Here are a few examples of adopting these configurations:

@jsvd jsvd marked this pull request as ready for review March 11, 2020 17:01
Comment thread travis/defaults.yml
@@ -0,0 +1,7 @@
os: linux
language: ruby

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, is there anything we might need the system installed ruby for?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, the travis config parser complains about us not setting any lang, we can also set this as generic

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also language: minimal (has Docker available) which we used before

@kares kares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆 for plugin CI testing.
we need to change the branch name, not sure whether to start tagging right off or just use master

Comment thread travis/exec.yml
@jsvd jsvd merged commit ae2173f into master Mar 17, 2020
@jsvd jsvd deleted the travis_refactor branch March 17, 2020 11:30
@jsvd jsvd mentioned this pull request Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants