test(chat): qualify model discovery and native cancellation

Signed-off-by: vastraliu <vastraliu@tencent.com>

Author: vastraliu

apps/presentation/dashboard/src/data/client-request-id.test.mjs

@@ -0,0 +1,11 @@
+import assert from "node:assert/strict";
+import { clientRequestId } from "./client-request-id.js";
+
+assert.equal(clientRequestId({ randomUUID: () => "host-native-identity" }), "host-native-identity");
+const insecureContext = { getRandomValues: (bytes) => {
+  for (let index = 0; index < bytes.length; index += 1) bytes[index] = index;
+  return bytes;
+} };
+assert.equal(clientRequestId(insecureContext), "00010203-0405-4607-8809-0a0b0c0d0e0f");
+assert.match(clientRequestId(), /^[a-f0-9]{8}-[a-f0-9]{4}-4[a-f0-9]{3}-[89ab][a-f0-9]{3}-[a-f0-9]{12}$/);
+console.log("Client request identity works without secure-context randomUUID");

tests/test_chat_model_catalog.py

@@ -0,0 +1,85 @@
+"""Catalog discovery follows the selected host without starting model Turns."""
+import json
+import sys
+from types import SimpleNamespace
+
+import pytest
+
+from loopx.chat_model_catalog import chat_model_catalog, codex_models
+from loopx.chat_model_catalog_api import ModelCatalogRequestMixin
+
+
+def _codex(tmp_path, *, malformed=False, legacy=False):
+    executable = tmp_path / "codex-fixture"
+    trace = tmp_path / "requests.jsonl"
+    executable.write_text(f"#!{sys.executable}\n" + f"trace={str(trace)!r}\nmalformed={malformed!r}\nlegacy={legacy!r}\n" + '''
+import json,os,sys
+if sys.argv[1:3] == ['debug','models']:
+ print(json.dumps({'models':[{'slug':'compat-model','base_instructions':'synthetic host instructions'}]}));sys.exit(0)
+for line in sys.stdin:
+ d=json.loads(line)
+ with open(trace,'a') as f:f.write(json.dumps({'method':d['method'],'home':os.environ.get('CODEX_HOME')})+'\\n')
+ if 'id' not in d:continue
+ if d['method']=='initialize':result={}
+ elif d['method']=='model/list':
+  if legacy and '-c' not in sys.argv:
+   print(json.dumps({'id':d['id'],'error':{'message':'model_catalog_json missing field base_instructions'}}),flush=True);continue
+  if malformed:result={'data':[],'nextCursor':'repeated'}
+  elif not d['params'].get('cursor'):
+   result={'data':[{'id':'host-one','model':'host-one','displayName':'Host One','base_instructions':'never project these'}],'nextCursor':'second'}
+  else:result={'data':[{'id':'host-two','model':'host-two','displayName':'Host Two'}],'nextCursor':None}
+ else:raise RuntimeError('Catalog must not start a thread or Turn')
+ print(json.dumps({'id':d['id'],'result':result}),flush=True)
+''')
+    executable.chmod(0o700)
+    return executable, trace
+
+
+def test_codex_model_list_pages_use_actual_home_and_never_start_a_turn(tmp_path):
+    executable, trace = _codex(tmp_path)
+    home = tmp_path / "codex-home"
+    result = codex_models(str(executable), home)
+    assert [model["id"] for model in result] == ["host-one", "host-two"]
+    assert "never project" not in json.dumps(result)
+    requests = [json.loads(line) for line in trace.read_text().splitlines()]
+    assert [r["method"] for r in requests] == ["initialize", "initialized", "model/list", "model/list"]
+    assert all(r["home"] == str(home) for r in requests)
+
+
+def test_invalid_pagination_is_unavailable_without_placeholder_models(tmp_path):
+    executable, _ = _codex(tmp_path, malformed=True)
+    controller = SimpleNamespace(codex_bin=str(executable), codex_home=tmp_path)
+    result = chat_model_catalog(controller, "codex")
+    assert result["available"] is False and result["models"] == []
+    assert str(tmp_path) not in json.dumps(result)
+
+
+def test_legacy_catalog_retry_remains_visible_in_discovery(tmp_path):
+    executable, _ = _codex(tmp_path, legacy=True)
+    result = chat_model_catalog(SimpleNamespace(codex_bin=str(executable), codex_home=tmp_path), "codex")
+    assert result["available"] is True and result["compatibility_applied"] is True
+    assert [row["id"] for row in result["models"]] == ["host-one", "host-two"]
+
+
+def test_native_picker_returns_declared_models_without_env_or_codex_defaults(monkeypatch, tmp_path):
+    monkeypatch.setenv("CLAUDE_CONFIG_DIR", str(tmp_path))
+    (tmp_path / "settings.json").write_text(json.dumps({"env": {"PRIVATE_FIELD": "not model metadata"},
+        "modelPicker": {"options": [{"model": "native-one[1m]", "label": "Native One"},
+                                    {"model": "native-two", "description": "Native Two"}]}}))
+    result = chat_model_catalog(SimpleNamespace(), "claude-code")
+    assert result["available"] and [row["id"] for row in result["models"]] == ["native-one[1m]", "native-two"]
+    assert "not model metadata" not in json.dumps(result)
+    assert str(tmp_path) not in json.dumps(result)
+    (tmp_path / "settings.json").write_text("[]")
+    assert chat_model_catalog(SimpleNamespace(), "claude-code")["available"] is False
+
+
+@pytest.mark.parametrize("query", ["", "?endpoint_id=", "?endpoint_id=codex&endpoint_id=claude-code", "?endpoint_id=codex&command=arbitrary"])
+def test_catalog_api_does_not_accept_commands_or_ambiguous_hosts(query):
+    class Handler(ModelCatalogRequestMixin):
+        path = "/api/chat/models" + query
+        def _send_error(self, message, **kwargs):
+            self.error = kwargs
+    handler = Handler()
+    handler._model_catalog()
+    assert handler.error["status"] == 400

tests/test_chat_native_tools.py

@@ -3,6 +3,8 @@
 import io
 import json
 import sys
+import threading
+import time
 from urllib.error import HTTPError, URLError
 from urllib.request import Request, urlopen
 
@@ -134,3 +136,32 @@ def test_native_manager_uses_existing_runtime_grant_and_configured_model(monkeyp
 def test_native_manager_vendor_default_never_inherits_codex_model():
     assert manager_model_config({}, endpoint="claude-code")["model"] == "sonnet"
     assert manager_model_config({}, endpoint="codex")["model"] == "gpt-6-astra"
+
+
+def test_interrupt_native_wrapper_stops_child_before_it_can_write(tmp_path):
+    marker = tmp_path / "child-side-effect.txt"
+    executable = tmp_path / "native-wrapper"
+    child = f"import time; from pathlib import Path; time.sleep(1); Path({str(marker)!r}).write_text('late effect')"
+    executable.write_text(f"#!{sys.executable}\nimport json,subprocess,sys\n"
+        + f"p=subprocess.Popen([sys.executable,'-c',{child!r}])\n"
+        + "print(json.dumps({'type':'stream_event','event':{'type':'content_block_start','content_block':{'type':'tool_use','name':'synthetic-child'}}}),flush=True)\np.wait()\n")
+    executable.chmod(0o700)
+    adapter = ClaudeCodeAdapter(str(executable), tmp_path, "synthetic-interrupt")
+    ready = threading.Event()
+    errors = []
+    def run():
+        try:
+            adapter.start_turn("Wait for owner", lambda kind, _: ready.set()
+                               if kind == "agent.phase" and adapter.current_process is not None else None)
+        except CodexChatAgentError as error:
+            errors.append(error)
+    worker = threading.Thread(target=run)
+    worker.start()
+    assert ready.wait(timeout=5)
+    process = adapter.current_process
+    adapter.interrupt_turn()
+    worker.join(timeout=3)
+    assert not worker.is_alive() and errors
+    assert process.poll() is not None and adapter.current_process is None
+    time.sleep(1.1)
+    assert not marker.exists(), "Native child survived owner interruption"