From dcab9394d5b40bf309fc94e6132e68c866b0305f Mon Sep 17 00:00:00 2001 From: song Date: Fri, 4 Sep 2026 19:46:02 +0800 Subject: [PATCH] fix(smokes): cover new goal configuration catalog features `examples/project/configure-goal-smoke.py` pinned the goal configuration catalog to eight feature ids, so the Full Public Smokes baseline went red once the catalog started reporting `local_authority_shadow` (Stage 2C local post-commit authority observation, #3882) and `periodic_report` (Goal-scoped periodic-report override, #3865/#3910). Extend the expected feature set and assert both features' default-off semantics for a Goal that never opted in: - `local_authority_shadow` is `experimental_opt_in`, reports the closed `{"enabled": False, "mode": None, "status": "disabled"}` summary, and its preview/apply commands follow the preview-without-execute contract. - `periodic_report` is `supported_explicit_override` with default `{"enabled": False, "timezone": "UTC"}`; a Goal without an override follows the machine default, so the catalog deliberately reports no Goal-scoped `current` value rather than a synthetic one. No product behavior or default changes; smoke-only. Validation: python3 examples/project/configure-goal-smoke.py Signed-off-by: song (cherry picked from commit ec9bf3c9c8704c84bf59157f2e2a0b5a8b78a99b) --- examples/project/configure-goal-smoke.py | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/examples/project/configure-goal-smoke.py b/examples/project/configure-goal-smoke.py index b7c6ddc161..7bf22be20f 100644 --- a/examples/project/configure-goal-smoke.py +++ b/examples/project/configure-goal-smoke.py @@ -208,6 +208,7 @@ def main() -> int: assert catalog["disclosure_policy"]["first_run_configuration_required"] is False features = {item["feature_id"]: item for item in catalog["features"]} assert set(features) == { + "local_authority_shadow", "multi_subagent", "peer_task_coordination", "explore_graph", @@ -216,7 +217,26 @@ def main() -> int: "reward_memory", "lark_event_inbox", "lark_kanban_heartbeat_sync", + "periodic_report", } + assert features["local_authority_shadow"]["availability"] == "experimental_opt_in" + assert features["local_authority_shadow"]["default"] == {"enabled": False} + assert features["local_authority_shadow"]["current"] == { + "enabled": False, + "mode": None, + "status": "disabled", + } + assert "--local-authority-shadow-file" in features[ + "local_authority_shadow" + ]["commands"]["preview_enable"] + assert "--execute" not in features["local_authority_shadow"]["commands"]["preview_enable"] + assert "--execute" in features["local_authority_shadow"]["commands"]["apply_enable"] + assert features["periodic_report"]["availability"] == "supported_explicit_override" + assert features["periodic_report"]["default"] == {"enabled": False, "timezone": "UTC"} + # A Goal without an explicit override follows the machine default, so the + # catalog reports no Goal-scoped current value instead of a synthetic one. + assert "current" not in features["periodic_report"], features["periodic_report"] + assert set(features["periodic_report"]["commands"]) == {"verify"} assert features["multi_subagent"]["current"]["enabled"] is True assert features["multi_subagent"]["required_inputs"] == {} assert "--allowed-domain" not in features["multi_subagent"]["commands"][