From bf2b2832e9cbed75c3e967464cbf0b2934f1de56 Mon Sep 17 00:00:00 2001 From: huangruiteng <14976749+huangruiteng@users.noreply.github.com> Date: Thu, 17 Sep 2026 11:41:26 +0800 Subject: [PATCH] chore(canary): refresh chat_actions' reviewed module ceiling after three steward repairs main has been red since #4587: `tests/canary/test_maintainability_ratchet.py` reports `unreviewed finding: module_metric_budget:loopx/chat_actions.py` because the module is 1604 lines against a reviewed ceiling of 1590. The failure reproduces on a clean `origin/main` worktree and on every open PR, so it blocks all merges including the pending steward stack. The growth is deliberate and already merged, not new debt invented here: the file was 1449 lines when the ceiling was set for #4567, then 1520 (#4582), 1575 (#4585) and 1604 (#4587). Those three repairs extended the single Chat action settlement owner with typed lane-level results (`lane_failure`, `lane_settlements`, bounded `details` on `mark_failed`) instead of a second settlement path, so the reviewer-visible decision this ledger records is to accept the module as the owner of that behaviour. It stays a bounded debt rather than a limit change: the default ceiling is 1500 lines, this module keeps its own 1604 entry, and `any_count` keeps its existing 52 headroom (currently 45). Extracting the lane-level settlement code now would rewrite work that three open PRs (#4590, #4600, #4602) are already changing in this module. Validation: `tests/canary -q` reports 21 passed; on `origin/main` before this change the same group fails with the unreviewed finding above. Signed-off-by: huangruiteng <14976749+huangruiteng@users.noreply.github.com> --- loopx/canary/module_metric_baseline.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/loopx/canary/module_metric_baseline.json b/loopx/canary/module_metric_baseline.json index 989df62710..ccbc6ab8af 100644 --- a/loopx/canary/module_metric_baseline.json +++ b/loopx/canary/module_metric_baseline.json @@ -33,7 +33,7 @@ "loopx/chat_actions.py": { "any_count": 52, "dict_any_count": 0, - "lines": 1590 + "lines": 1604 }, "loopx/chat_runtime.py": { "any_count": 35,