From db08c4ee15199cd9e78b890d49688731740ca857 Mon Sep 17 00:00:00 2001 From: hahahahahayesyeseys <95999512+hahahahahayesyeseys@users.noreply.github.com> Date: Sun, 20 Sep 2026 22:29:56 +0800 Subject: [PATCH] test(update-notes): stop pinning the pre-transfer repository address The generator publishes pull links built from PULL_URL, which now names the canonical repository. The quality smoke still compared against a hand-copied pre-transfer address, so the deterministic draft check failed on every branch that ran it: both full-public-smokes and the biweekly update-note draft job are red on main with this same assertion. Assert the canonical address once, against PULL_URL itself, and build the expected bullet from that same value. The check keeps its teeth against a wrong address while a future repository move can no longer break it by copying the old one into an expectation. Refs #4753 Signed-off-by: hahahahahayesyeseys <95999512+hahahahahayesyeseys@users.noreply.github.com> --- examples/update-notes-generator-quality-smoke.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/update-notes-generator-quality-smoke.py b/examples/update-notes-generator-quality-smoke.py index 8629093fce..2cd6a2e2e1 100644 --- a/examples/update-notes-generator-quality-smoke.py +++ b/examples/update-notes-generator-quality-smoke.py @@ -63,6 +63,10 @@ def fake_run_git(args: list[str]) -> str: def validate_compact_ranking(module) -> None: + # Pinned once, here, as the canonical address the generator must publish. + # Every other expectation in this smoke composes from ``module.PULL_URL`` so a + # future repository move cannot silently re-break a hand-copied bullet. + assert module.PULL_URL == "https://github.com/loopx-project/loopx/pull" commits = [ module.Commit("a", "docs: explain issue-fix", 40), module.Commit("b", "fix: preserve issue-fix evidence", 39), @@ -72,7 +76,7 @@ def validate_compact_ranking(module) -> None: ranked = grouped["Issue-fix workflow"] assert [item.pr_number for item in ranked] == [38, 39, 40], ranked bullets = module.bulletize(ranked, limit=2) - assert bullets[0].startswith("- [#38](https://github.com/huangruiteng/loopx/pull/38)"), bullets + assert bullets[0] == f"- [#38]({module.PULL_URL}/38) feat: add issue-fix lifecycle" assert bullets[-1] == "- ...and 1 more merged PR in this theme.", bullets note = module.render_note( module.Window(module.parse_date("2026-07-01"), module.parse_date("2026-07-14")),