feat: Add failed response error reporting using the feedback system#329
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new “failed request error report” feature to the Unreal SDK that packages details from a failed FLootLockerResponse into a structured feedback entry and submits it via the existing feedback system (matching the Unity SDK behavior).
Changes:
- Added
SendLootLockerErrorReportto both the C++ (ULootLockerSDKManager) and Blueprint (ULootLockerManager) facades. - Implemented failed-request detail capture in
ULootLockerHttpClient(bounded in-memory history + feedback category id lookup/caching). - Introduced
FLootLockerFailedRequestReportas the serialized payload structure.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| LootLockerSDK/Source/LootLockerSDK/Public/LootLockerSDKManager.h | Public C++ API: declares SendLootLockerErrorReport and documents expected behavior. |
| LootLockerSDK/Source/LootLockerSDK/Public/LootLockerManager.h | Blueprint API: exposes SendLootLockerErrorReport to Blueprints. |
| LootLockerSDK/Source/LootLockerSDK/Public/LootLockerHttpClient.h | Adds failure-reporting public helpers (category-id caching + report retrieval). |
| LootLockerSDK/Source/LootLockerSDK/Public/LootLockerFailedRequestReport.h | New USTRUCT payload describing captured failure details. |
| LootLockerSDK/Source/LootLockerSDK/Private/LootLockerSDKManager.cpp | Implements SendLootLockerErrorReport (validation + serialization + feedback send). |
| LootLockerSDK/Source/LootLockerSDK/Private/LootLockerManager.cpp | Blueprint wrapper that forwards to ULootLockerSDKManager. |
| LootLockerSDK/Source/LootLockerSDK/Private/LootLockerHttpClient.cpp | Captures/stores failed request info and resolves the feedback category id. |
kirre-bylund
force-pushed
the
feature/report-error-method
branch
from
f2143a2 to
5cbcf68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes lootlocker/index#1473
Mimics lootlocker/unity-sdk#452
Description
Added functionality to send a failed LootLocker Response as a pre-structured feedback entry to LootLocker.