feat(i18n): seed dash root-landing marketing keys (8 locales)#56
Merged
Conversation
Companion to core_api PR (Phase 4 of dash-root-landing plan). Adds the canonical en-US source-of-truth for the dash.loyalty.dog marketing landing copy: hero, nav, pricing, faq.cc + faq.charge, cookies banner, and footer links. The TS bundle in core_api/frontend/src/lib/i18n-utils.ts mirrors these keys for the en-US offline fallback. Other 7 locales (en-GB, es-ES, es-MX, fr, it, pt-BR, pt-PT) will be Haiku-translated and uploaded to Crowdin (project_id 881724) in a follow-up commit. Pricing literal `$29` is intentionally NOT translated — USD-only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Phase 4, Task 4.4 of dash-root-landing plan. Translates the en-US marketing keys (added in 9b2ee94) to the other 7 supported locales: - en-GB: British spellings (programme, authorised, customise) - es-ES: Peninsular Spanish, vosotros formality - es-MX: Latin American Spanish, ustedes formality - fr: France French, formal "vous" - it: Italian - pt-BR: Brazilian Portuguese (PDV, inscrição, painel) - pt-PT: European Portuguese (caixa, registo, ecrã, Gerir) Translations performed by Claude Haiku via Agent tool. Verified each file is valid JSON with the same key tree as en-US. Two terms held constant across all locales: the literal `$29` (USD-only pricing) and the `Stripe` brand name. Next step: upload to Crowdin (project_id 881724) for translator review (`crowdin upload sources` with CROWDIN_PERSONAL_TOKEN). The JSON files remain the authoritative source on disk; Crowdin is the bookkeeping/review system. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
the
size:L
Contributor
|
CodeAnt AI finished reviewing your PR. |
![paperclip-access[bot]](https://avatars.githubusercontent.com/u/103157344?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review — LOY-221
Overall: Approve with one note. 8-locale marketing key seeding. Clean diff, consistent structure across all locales.
P2 — Pricing amount hardcoded as USD in non-USD markets
es-ES/marketing.json, es-MX/marketing.json, and pt-PT/marketing.json display "amount": "$29". Spanish and Portuguese customers will see USD pricing which is likely not intended. Either:
- Translate to local currency equivalents (e.g.
29,99 €for EU markets), OR - Add a note that the displayed amount is intentional and handled separately by the payment processor
The pricing.disclaimer strings already handle the Stripe/cancellation context correctly per locale — this is purely a display concern.
Style observations (non-blocking)
- en-GB uses British spellings (
authorised,programme) while en-US uses American spellings — correct and intentional. ✓ - All 8 locales maintain identical JSON key structure ✓
- FAQ items (
cc,charge) present in all locales with bothqandafields ✓
No blockers. Ready to merge or address the pricing note.
6 tasks
haim-barad
added a commit
that referenced
this pull request
Apr 26, 2026
#57) Adds the canonical marketing keys for the dash.loyalty.dog landing page directly to main, per the localization-platform repo workflow (no dev → staging → main progression for this repo). Sections (en-US hand-authored, 7 other locales Haiku-translated): - hero, nav, pricing (with USD-only `$29` literal) - faq.cc + faq.charge - cookies banner - footer links - integrations.{wordpress,shopify,eposnow,zapier,standalone,clover,square}.desc 8 locales: en-US (default), en-GB, es-ES, es-MX, fr, it, pt-BR, pt-PT. Brand names held verbatim across all locales: WordPress, WooCommerce, Shopify, EPOS Now, Zapier, Clover, Square. Pricing literal `$29` also constant. Companion to the core_api `feat/dash-landing-frontend` PR (Phase 4-5 of the dash-root-landing plan): the frontend `enUSFallback.marketing` in `frontend/src/lib/i18n-utils.ts` mirrors these keys for the offline en-US fallback; non-en-US locales fetch this marketing namespace from the HTTP backend at runtime. Note: PR #56 on the development branch superseded — this PR delivers the same content (plus the new integrations subtree) directly to main. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
Companion PR to core_api
feat/dash-landing-frontend(Phase 4 of the dash-root-landing plan). Adds the canonical en-US marketing keys for the dash.loyalty.dog landing page, then Haiku-translates them to the other 7 supported locales.packages/i18n/locales/en-US/marketing.jsonKey sections: hero, nav, pricing, faq (cc + charge), cookies banner, footer.
Two values held constant across all locales:
$29(USD-only pricing literal) andStripe(brand name).Test plan
pricing.amount === "$29"in every localeStripepreserved verbatim in every locale🤖 Generated with Claude Code
CodeAnt-AI Description
Add marketing landing page copy in 8 locales
What Changed
Impact
✅ Localized landing page copy✅ Consistent pricing and brand wording across regions✅ Clearer signup and trial messaging for international visitors🔄 Retrigger CodeAnt AI Review
Details
💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.