[WIP] refactor: Use writer without allocating entire output#8
Draft
LauH1987 wants to merge 10 commits into
Draft
[WIP] refactor: Use writer without allocating entire output#8LauH1987 wants to merge 10 commits into
LauH1987 wants to merge 10 commits into
Conversation
Contributor
Author
|
I personally find the expressions like let SeqState::NotSeq = self.seq_state else { ... }quite hard to comprehend, so alternatively using the if matches!(ser.seq_state, SeqState::NotSeq).not() { ... } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on top of my other PR (#7). When debugging the issue in that PR I noticed that the current implementation would allocate the entire output as a string even when using the
to_writerfunction. This PR tries to avoid this.Having never implemented something like this before I took a lot of inspiration from the
serde_jsoncrate. The goal is to eventually be able to use the serializer by itself for instance usingserde_transcode.I understand that env-files are rarely very large so serializing to memory before outputting is usually not an issue.
There are still some things missing like doc strings and a public
Serializer::newfunction, so I'm marking this PR as a draft. I didn't want to sink more time into this before getting feedback.