hotfix: pin pypa/gh-action-pypi-publish to commit SHA not tag-object SHA#53
Merged
Conversation
#35 pinned `pypa/gh-action-pypi-publish` to `6733eb7d741f0b11ec6a39b58540dab7590f9b7d`, which is the **tag object** SHA for v1.14.0, not the commit it points to. The publish action's Docker image is built per commit SHA, so pulling `ghcr.io/pypa/gh-action-pypi-publish:6733eb7d...` failed with "manifest unknown" and the v0.3.0 PyPI upload never happened. The actual v1.14.0 commit SHA is `cef221092ed1bacb1cc03d23a2d87d1d172e277b` (the tag object dereferences to it, and `refs/heads/release/v1` agrees). Also adding `workflow_dispatch:` trigger so we can re-run publish without deleting/recreating the GitHub release. The release-only trigger left us with no path to retry after the failure. Closes #52
luciferreeves
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
The v0.3.0 publish workflow failed at the Docker image pull step:
PyPI upload didn't happen. v0.3.0 tag and GitHub release exist, but the package is not yet on PyPI.
Root cause
#35 pinned
pypa/gh-action-pypi-publishto6733eb7d741f0b11ec6a39b58540dab7590f9b7d. That's the tag-object SHA for v1.14.0, not the commit SHA the tag points to. Annotated tags have their own SHA which dereferences to a commit, and I used.object.shafromgit/refs/tags/v1.14.0directly without checking.object.type(which wastag, notcommit).The actual v1.14.0 commit SHA is
cef221092ed1bacb1cc03d23a2d87d1d172e277b(verified by following the tag object, and cross-checked againstrefs/heads/release/v1which points at the same commit).Docker images for the publish action are tagged with the commit SHA, not the tag-object SHA, hence "manifest unknown."
Fix
Two changes to
.github/workflows/python-publish.yml:6733eb7d…→cef221092…(still v1.14.0, just the right SHA this time).workflow_dispatch:trigger so we can manually re-run publish after merge without deleting/recreating the release.After merge
Run
gh workflow run python-publish.ymlto dispatch the fixed workflow againstmain. The package contents are identical to what's at the v0.3.0 tag (we only changed the workflow file), so PyPI getsedify==0.3.0as intended.Closes #52