From 069b800b533010abed64a976ee7f2583c77dc899 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=B6ren=20Gregor?= Date: Wed, 24 Jun 2026 10:28:03 +0200 Subject: [PATCH] fix(pricing): correct formatterStyle parameter type from string to int The NumberFormatter::CURRENCY constant is an int, so the type hint was incorrect. This fixes strict type compatibility when passing formatter style constants. --- packages/core/src/Pricing/DefaultPriceFormatter.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/core/src/Pricing/DefaultPriceFormatter.php b/packages/core/src/Pricing/DefaultPriceFormatter.php index 397dd40d7d..49f18edffa 100644 --- a/packages/core/src/Pricing/DefaultPriceFormatter.php +++ b/packages/core/src/Pricing/DefaultPriceFormatter.php @@ -33,17 +33,17 @@ public function unitDecimal(bool $rounding = true): float return $rounding ? round($convertedValue, $this->currency->decimal_places) : $convertedValue; } - public function formatted(?string $locale = null, string $formatterStyle = NumberFormatter::CURRENCY, ?int $decimalPlaces = null, bool $trimTrailingZeros = true): mixed + public function formatted(?string $locale = null, int $formatterStyle = NumberFormatter::CURRENCY, ?int $decimalPlaces = null, bool $trimTrailingZeros = true): mixed { return $this->formatValue($this->decimal(false), $locale, $formatterStyle, $decimalPlaces, $trimTrailingZeros); } - public function unitFormatted(?string $locale = null, string $formatterStyle = NumberFormatter::CURRENCY, ?int $decimalPlaces = null, bool $trimTrailingZeros = true): mixed + public function unitFormatted(?string $locale = null, int $formatterStyle = NumberFormatter::CURRENCY, ?int $decimalPlaces = null, bool $trimTrailingZeros = true): mixed { return $this->formatValue($this->unitDecimal(false), $locale, $formatterStyle, $decimalPlaces, $trimTrailingZeros); } - protected function formatValue(int|float $value, ?string $locale = null, string $formatterStyle = NumberFormatter::CURRENCY, ?int $decimalPlaces = null, bool $trimTrailingZeros = true): mixed + protected function formatValue(int|float $value, ?string $locale = null, int $formatterStyle = NumberFormatter::CURRENCY, ?int $decimalPlaces = null, bool $trimTrailingZeros = true): mixed { if (! $locale) { $locale = App::currentLocale();