Skip to content

Minified JS requires strings; uglifyjs optimizes away cast-to-string #12

Description

@eclipticplane

Commit 2f27d9b added

label = "" + label;

to allow you to use Notificon(3) instead of Notificon("3"). However, the minified version with uglifyjs optimizes away this check -- so using the .min version differs from the full file.

In fact, the resulting favicon is completely different in the full version versus the minified version. It appears that the minified version is not up to date with the full file.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions