Skip to content

Bump cgmath to 0.18.0 #12

@danakj

Description

@danakj

The new cgmath has some nice helpers added.

The CHANGELOG.md specifies a breaking change however: https://github.com/rustgd/cgmath/blob/master/CHANGELOG.md

Breaking: Quaternion memory layout changed to [x, y, z, w]. The From and Into impls for [S; 4] and (S, S, S, S) have been changed accordingly.

The data has moved from

pub struct Quaternion {
pub s: S,
pub v: Vector3,
}

To

pub struct Quaternion {
pub v: Vector3,
pub s: S,
}

I'm not sure if mgf depends on from/to [S;4] or (S,S,S,S). It seems unlikely to me, since those are mostly for interfacing to something like OpenGL, but I wanted to raise the issue here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions