Give base IsMatch method a clearer signature?

[markashleybell]

Currently we have public bool IsMatch(string path, bool pathIsDirectory), but it does cause a bit of "boolean blindness" unless you label the parameter... for example, without looking at the source, what does the second parameter mean in this case?

rule.IsMatch(directory.FullName, true);

Might be nicer to either replace it with an enum, or make that method internal (or even private) and add IsFileMatch and IsDirectoryMatch methods, so it's really explicit?

[markashleybell]

This would obviously be a breaking change, so would need to be part of the next major version bump.

[nojaf]

Perhaps you can introduce the new methods as a part of a minor and mark the current IsMatch as deprecated but keep it as a facade thing.

[markashleybell]

Good idea!