register_count or related. Not working

[nikito7]

https://github.com/esphome/esphome/pull/2654/files#diff-0ea229c132333ba55ad80ec822674e1b81f7fa194d1f57bd3ff86d38a062b047R267

@martgras how work register_count now?

You killed single register 32bits 😂

[nikito7]

[00:27:57][D][text_sensor:067]: 'EB3 Tariff': Sending state 'Vazio'
[00:27:57][V][modbus_controller:028]: Sending next modbus command to device 1 register 0x16 count 2
[00:27:57][V][modbus:184]: Modbus write: 01.04.00.16.00.02.90.0F (8)
[00:27:57][V][modbus_controller:447]: Command sent 4 0x16 2
[00:27:57][V][modbus:058]: Modbus received Byte  1 (0X1)
[00:27:57][V][modbus:058]: Modbus received Byte  4 (0X4)
[00:27:57][V][modbus:058]: Modbus received Byte  8 (0X8)
[00:27:57][V][modbus:058]: Modbus received Byte  0 (0X0)
[00:27:57][V][modbus:058]: Modbus received Byte  30 (0X1e)
[00:27:57][V][modbus:058]: Modbus received Byte  206 (0Xce)
[00:27:57][V][modbus:058]: Modbus received Byte  76 (0X4c)
[00:27:57][V][modbus:058]: Modbus received Byte  0 (0X0)
[00:27:57][V][modbus:058]: Modbus received Byte  0 (0X0)
[00:27:57][V][modbus:058]: Modbus received Byte  2 (0X2)
[00:27:57][V][modbus:058]: Modbus received Byte  34 (0X22)
[00:27:57][V][modbus:058]: Modbus received Byte  90 (0X5a)
[00:27:57][V][modbus:058]: Modbus received Byte  149 (0X95)
[00:27:57][V][modbus_controller:048]: Modbus response queued
[00:27:57][V][component:199]: Component modbus took a long time for an operation (0.08 s).
[00:27:57][V][component:200]: Components should block for at most 20-30ms.
[00:27:57][V][modbus_controller:056]: Process modbus response for address 0x16 size: 8
[00:27:57][V][modbus_controller:096]: data for register address : 0x16 :
[00:27:57][D][modbus_controller.sensor:030]: Sensor new state: 2018892.00
[00:27:57][V][sensor:062]: 'EB3 Import': Received new state 2018892.000000
[00:27:57][D][sensor:113]: 'EB3 Import': Sending state 2018.89209 kWh with 1 decimals of accuracy
[00:27:57][D][modbus_controller.sensor:030]: Sensor new state: 3461087232.00
[00:27:57][V][sensor:062]: 'EB3 Export': Received new state 3461087232.000000
[00:27:57][D][sensor:113]: 'EB3 Export': Sending state 3461087.50000 kWh with 3 decimals of accuracy
[00:27:57][V][component:199]: Component modbus_controller took a long time for an operation (0.06 s).
[00:27:57][V][component:200]: Components should block for at most 20-30ms.

[martgras]

yes looks like I broke it :(
Please test

external_components:
  - source: github://martgras/esphome@modbus-regsize
    components: ["modbus_controller"]

and set response_size: 2 for the 32bit registers. This is will override the default size (register_count * 2)
register_count is mainly used to optimize register ranges : see the note at https://next.esphome.io/components/sensor/modbus_controller.html

[martgras]

Planning to change the docs to:

• register_count: (Optional): only required for uncommon response encodings or to optimize modbus communication
  The number of registers this data point spans. Overrides the defaults determined by value_type.
  If no value for register_count is provided, it is calculated based on the register type.

  The default size for 1 register is 16 bits (1 Word). Some devices are not adhering to this convention and have registers larger than 16 bits. In this case register_count and response_size must be set. For example, if your modbus device uses 1 registers for a FP32 value instead the default of two set register_count: 1 and response_size: 2.

• response_size: (Optional): Size of the response for the register in bytes. Defaults to register_count*2.

[nikito7]

  response_size: 4

working
thanks

[martgras]

ah yes of course 4 not 2 - thanks
esphome#2845

[nikito7]

Unrelated but, last dev breaks OTA

[martgras]

Yes esphome#2852