Skip to content

Issue when referencing JS in HTML instead of via a bundler ( BodyScrollLock, dayJS dependencies and its onOpen, onClose events) #110

@TrendyTim

Description

@TrendyTim

Even though this seems to be a dead project, just thought id mention this here for anyone else going to use this project outside a bundler.

This is unworkable in its current state when used in webpages when just referencing the JS

Even if you include body scroll lock and dayjs dependencies and apply a fix for case discrepancies.

<script>
BodyScrollLock = bodyScrollLock; Dayjs=dayjs;
</script>

it ignores the vue recommendations for event naming and emits onOpen and onClose making them impossible to handle (why vue never just enforced lowercase for event names i dont know).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions