Skip to content

Fix DST change causing getWeekViewEventSpan to return wrong span#54

Merged
mattlewis92 merged 1 commit into
mattlewis92:mainfrom
nmihaylov543:nmihaylov/dst-when-excluding-seconds-fix
Mar 19, 2026
Merged

Fix DST change causing getWeekViewEventSpan to return wrong span#54
mattlewis92 merged 1 commit into
mattlewis92:mainfrom
nmihaylov543:nmihaylov/dst-when-excluding-seconds-fix

Conversation

@nmihaylov543
Copy link
Copy Markdown
Contributor

@nmihaylov543 nmihaylov543 commented Mar 19, 2026

DST time change was causing the hour of the end date to end up after the iterator's hour. That was resulting in one more iteration in the while loop.

Added tests for the exact case as well

Copy link
Copy Markdown
Owner

@mattlewis92 mattlewis92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mattlewis92 mattlewis92 merged commit 03574f0 into mattlewis92:main Mar 19, 2026
1 check passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b07c733) to head (e656f69).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          494       498    +4     
  Branches        95        96    +1     
=========================================
+ Hits           494       498    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants