Search results pagination

[mbudm]

Modify the query API to default to return paginated records - with some limit of say 50 or 100 results.

Or leave as is and expect the client to default to time limited (month?) search?

Probably both.

[mbudm]

I had a bit of a go at this but looks like there's some refactoring to do beforehand. The functional tests were breaking in unexpected ways after applying my preferred date and limit changes:

• proposed query request interface adds the limit, lastRetrievedBirthtime, breakDateRestriction and clientId properties.
• logic for determining which date range to send to db

So I've reverted the changes and will move this work to the alpha branch.

First up though I want to make the functional tests less environment reliant/affected. I don't like how the functional tests leave behind records. It makes for some messy logs (eg multiples of the same image in queries) which makes it hard to diagnose issues. The merge person test is also problematic, it relies on multiple people existing which is not a system state created by the functional test itself. So I've had to quieten this test if the people count is less than 2.

Options

• have an exclusive environment for the functional test. Tempting but I kind of like sharing with ad hoc setup in the dev environment. functional tests should be robust enough to handle a little reality.
• make the functional test operation on a given environment idempotent. This option I like much better, as it means I could also potentially apply the functional tests to production.

Plan

• refactor the functional test to be idempotent
  • remove all images and records that are added
  • ensure the face and person records are removed from rekognition also
  • allow a person merge to be reversed/ or if all faces merged into a person are removed then that is reflected in the person data (may already be done)
• add more explicit types (in the move to typescript I was most thorough in the faces.ts module. Others were bare minimum)
• then re apply changes on alpha branch and I may have a chance of debugging any issues!

[mbudm]

query API complete, need to update client to paginate.