fix: add OpenAPI extension index signature to contact/license types#160
Merged
Conversation
OpenApiContactObject and OpenApiLicenseObject were missing the
`[key: \`x-${string}\`]: any` index signature that zod-openapi's
ContactObject and LicenseObject require, causing TS2322 in
generateOpenApiDocument and breaking CI on master.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mcampa
added a commit
that referenced
this pull request
May 22, 2026
- feat: contact/license fields on GenerateOpenApiDocumentOptions (#157) - feat: support zod v3 (>=3.25) alongside v4 via zod/v4 permalink (#161) - fix: bump zod-openapi to 5.4.6 and raise peer dep to ^5.4.4 to prevent the discriminated-union crash on zod >=4.1.13 (#162) - fix: add x-${string} index signature to contact/license types (#160) - chore: bump h3 to ^1.15.5 (#159) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Master CI has been failing since #157 with:
```
src/generator/index.ts(71,5): error TS2322:
Type '{ license?: OpenApiLicenseObject | undefined; contact?: OpenApiContactObject | undefined; ... }'
is not assignable to type 'InfoObject'.
...
Index signature for type `x-${string}` is missing in type 'OpenApiContactObject'.
```
`zod-openapi`'s `ContactObject` and `LicenseObject` require an `[key: `x-${string}`]: any` index signature for OpenAPI extension fields. The local `OpenApiContactObject` and `OpenApiLicenseObject` interfaces introduced in #157 didn't include it, so `opts.contact` / `opts.license` couldn't be assigned to the `info` field at `src/generator/index.ts:71`.
Added the missing index signature to both interfaces.
Test plan
🤖 Generated with Claude Code