Hey Dan,
Thanks for merging in our basic composer integration. We were a bit hasty with our pull request though as it was somewhat incomplete. It was initially done at work and I was hoping to come back to it but I'm sure you know how things go. Sorry about that.
I've forked your repo and created a composer-integration branch here. The original pull request requires the user to load in phpfp.php from the vendor directory which isn't ideal. Furthermore the reference to "phpfp/fp.js" within that file would cause issues as it no longer sits in the document root. You can see how the code change inside composer-integration could be used here. The implementation of getViewElement isn't particularly nice but does result in minimal effort on the user's part to get it integrated into their application.
I must make clear that this code change is backwards incompatible. If you did eventually merge in the composer-integration branch I'd suggest branching off a commit which was before any composer stuff so people who might be pulling in your code via git submodule could at least tie their submodule dependency to that branch.
If you're willing to entertain merging in this code I'll happily update the documentation related to composer as it's not quite right. Incidentally if you're open to some refactoring, slight additions and perhaps tackling some items in your todo list I might be up for it.
Let me know what you think mate. Cheers.
Hey Dan,
Thanks for merging in our basic composer integration. We were a bit hasty with our pull request though as it was somewhat incomplete. It was initially done at work and I was hoping to come back to it but I'm sure you know how things go. Sorry about that.
I've forked your repo and created a
composer-integrationbranch here. The original pull request requires the user to load inphpfp.phpfrom the vendor directory which isn't ideal. Furthermore the reference to "phpfp/fp.js" within that file would cause issues as it no longer sits in the document root. You can see how the code change insidecomposer-integrationcould be used here. The implementation of getViewElement isn't particularly nice but does result in minimal effort on the user's part to get it integrated into their application.I must make clear that this code change is backwards incompatible. If you did eventually merge in the
composer-integrationbranch I'd suggest branching off a commit which was before any composer stuff so people who might be pulling in your code viagit submodulecould at least tie their submodule dependency to that branch.If you're willing to entertain merging in this code I'll happily update the documentation related to composer as it's not quite right. Incidentally if you're open to some refactoring, slight additions and perhaps tackling some items in your todo list I might be up for it.
Let me know what you think mate. Cheers.